Skip to content

Conversation

@soltysh
Copy link
Contributor

@soltysh soltysh commented Feb 25, 2015

@mfojtik this is to address the race problem you've had in #1138, see this comment

//cc @bparees @smarterclayton

@soltysh
Copy link
Contributor Author

soltysh commented Feb 25, 2015

[test]

@bparees
Copy link
Contributor

bparees commented Feb 25, 2015

lgtm but i'm not sure why it's necessary, aren't these tests isolated enough to avoid this problem?

@mfojtik
Copy link
Contributor

mfojtik commented Feb 25, 2015

@bparees got a race today with STI environment PR... this seems to cause it...

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1169/)

@mfojtik
Copy link
Contributor

mfojtik commented Feb 25, 2015

LGTM

On Wed, Feb 25, 2015 at 5:12 PM, OpenShift Bot [email protected]
wrote:

Evaluated for origin up to 8ed39ca
8ed39ca


Reply to this email directly or view it on GitHub
#1144 (comment).


Michal Fojtik <[email protected] [email protected]>
Red Hat OpenShift, Engineering

@soltysh
Copy link
Contributor Author

soltysh commented Feb 25, 2015

lgtm but i'm not sure why it's necessary, aren't these tests isolated enough to avoid this problem?

I was hoping for that, since @smarterclayton put each of them in separate process in 5bcc917
But since we're actually using exactly the same image name, we're asking for troubles with that, so it's better no to do it IMHO.

@bparees
Copy link
Contributor

bparees commented Feb 25, 2015

@mfojtik yeah i saw the discussion, just not convinced this is the solution. or the right solution, anyway. if our integration tests are still coupled, we ought to figure out why.

@mfojtik
Copy link
Contributor

mfojtik commented Feb 26, 2015

[merge]

@bparees will merge this with a little hope it will fix #1158

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1041/) (Image: devenv-fedora_897)

@openshift-bot
Copy link
Contributor

Evaluated for origin up to 8ed39ca

openshift-bot pushed a commit that referenced this pull request Feb 26, 2015
@openshift-bot openshift-bot merged commit 95c896e into openshift:master Feb 26, 2015
@soltysh soltysh deleted the image_names branch March 10, 2015 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants