Skip to content

Management console create from template #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-bot merged 1 commit into from
Mar 9, 2015
Merged

Management console create from template #1129

openshift-bot merged 1 commit into from
Mar 9, 2015

Conversation

@csrwng
Copy link
Contributor

@csrwng csrwng commented Feb 24, 2015

No description provided.

jwforres
jwforres reviewed Feb 24, 2015
View reviewed changes
assets/app/scripts/controllers/newfromtemplate.js Outdated
Copy link
Member

@jwforres jwforres Feb 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll probably need this in other places, might be nice to just make this an attribute directive http://stackoverflow.com/a/23351154

Copy link
Contributor Author

@csrwng csrwng Feb 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

@csrwng csrwng force-pushed the creation_flow branch 5 times, most recently from 0063318 to 136510c Compare February 27, 2015 22:55
@smarterclayton smarterclayton modified the milestone: 0.5.0 Mar 2, 2015
@brenton
Copy link
Contributor

brenton commented Mar 3, 2015

Is there a story for this PR? I'm curious if this if for the v2-like quickstart experience from the web console.

@csrwng
Copy link
Contributor Author

csrwng commented Mar 3, 2015

@brenton there is - https://trello.com/c/g7dGiJuD/456-8-create-application-from-a-template-uicomp-beta3

@brenton
Copy link
Contributor

brenton commented Mar 3, 2015

Thanks! That story answers my other questions.

@csrwng csrwng force-pushed the creation_flow branch 2 times, most recently from 5b5b611 to e259a7e Compare March 4, 2015 21:52
jwforres
jwforres reviewed Mar 5, 2015
View reviewed changes
assets/app/scripts/controllers/newfromtemplate.js Outdated
Copy link
Member

@jwforres jwforres Mar 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should update this since we aren't going to do create from URL for now

@csrwng csrwng force-pushed the creation_flow branch 2 times, most recently from a2d11d1 to fa109fd Compare March 6, 2015 21:14
@csrwng
Copy link
Contributor Author

csrwng commented Mar 6, 2015

I've now updated the code with the latest review fixes

@csrwng
Copy link
Contributor Author

csrwng commented Mar 6, 2015

@jwforres Only remaining issue is a directive to display icons. Was thinking that can be done in a separate PR?

@csrwng csrwng force-pushed the creation_flow branch 3 times, most recently from c3e47ca to 1d45bdc Compare March 9, 2015 14:53
@jwforres
Copy link
Member

jwforres commented Mar 9, 2015

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 9, 2015

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1137/) (Image: devenv-fedora_1000)

@csrwng
Management Console - Create from template
ff795d7 
Contributions by:
@jwforres - Template catalog, select template, bindata fix
@sg00dwin - Style/UI updates, markup and css
@jwforres
Copy link
Member

jwforres commented Mar 9, 2015

should be fixed now, [merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 9, 2015

Evaluated for origin up to ff795d7

openshift-bot pushed a commit that referenced this pull request Mar 9, 2015
Merge pull request #1129 from csrwng/creation_flow
9ec70f7 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit 9ec70f7 into openshift:master Mar 9, 2015
@csrwng csrwng deleted the creation_flow branch July 20, 2015 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.5.0 (beta3)

Development

Successfully merging this pull request may close these issues.

6 participants

@csrwng @brenton @liggitt @smarterclayton @jwforres @openshift-bot