make build output optional #1119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparees
force-pushed
the
optional_output
branch
from
e0f0348 to
bad101b
Compare
Contributor
Author
|
@smarterclayton per your request. |
Contributor
Author
|
[test] |
Contributor
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_openshift3/1170/) |
Contributor
There was a problem hiding this comment.
With this condition you'll still end build when To is not defined and if I understood @smarterclayton correctly he wanted to have no output defined at all.
Contributor
Author
There was a problem hiding this comment.
No, if Output.To==nil we'll fall through to "output=false" but still run the build, which is as desired.
bparees
force-pushed
the
optional_output
branch
from
bad101b to
bca591c
Compare
Contributor
Author
Contributor
Author
|
[merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1035/) (Image: devenv-fedora_889) |
Contributor
|
Evaluated for origin up to bca591c |
openshift-bot
pushed a commit
that referenced
this pull request
Feb 25, 2015
Merged by openshift-bot
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.