Skip to content

Conversation

@deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 23, 2015

Updates to the sample app readme that add instructions for properly authorizing a user to see a project and make use of the new-project command.

/cc @smarterclayton @liggitt

@deads2k
Copy link
Contributor Author

deads2k commented Feb 23, 2015

In response to #999 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the user test-admin"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nest this under the "Optional: View in web console" step? Just so they can skip it if they don't care about the web browser

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step is labelled optional. You can look at two times. Once to see the docker registry deployed and once to see the rest of the test resources created.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, nm

@liggitt
Copy link
Contributor

liggitt commented Feb 23, 2015

Remove the project.json, and the reference to downloading it in container-setup.md?

@liggitt
Copy link
Contributor

liggitt commented Feb 23, 2015

not sure how aggressive we're being with examples following best practices (e.g. "your script that used project.json will now break because that's not how we want you creating it"). @bparees, you have an opinion?

@bparees
Copy link
Contributor

bparees commented Feb 23, 2015

@liggitt yeah we should try to keep the readme following best practices since it's probably something a lot of people will end up monkey-see-monkey-doing.

@deads2k
Copy link
Contributor Author

deads2k commented Feb 23, 2015

@liggitt updated for comments.

@liggitt
Copy link
Contributor

liggitt commented Feb 24, 2015

LGTM, squash and merge

@deads2k deads2k force-pushed the deads-update-readme branch from d1704f6 to 3079d08 Compare February 24, 2015 16:30
@deads2k
Copy link
Contributor Author

deads2k commented Feb 24, 2015

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1016/) (Image: devenv-fedora_869)

@openshift-bot
Copy link
Contributor

Evaluated for origin up to 3079d08

openshift-bot pushed a commit that referenced this pull request Feb 24, 2015
@openshift-bot openshift-bot merged commit f4221c5 into openshift:master Feb 24, 2015
@deads2k deads2k deleted the deads-update-readme branch February 27, 2015 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants