-
Notifications
You must be signed in to change notification settings - Fork 4.8k
update readme to take advantage of new-project #1104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
In response to #999 (comment) |
examples/sample-app/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the user test-admin"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nest this under the "Optional: View in web console" step? Just so they can skip it if they don't care about the web browser
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step is labelled optional. You can look at two times. Once to see the docker registry deployed and once to see the rest of the test resources created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, nm
|
Remove the project.json, and the reference to downloading it in container-setup.md? |
|
not sure how aggressive we're being with examples following best practices (e.g. "your script that used project.json will now break because that's not how we want you creating it"). @bparees, you have an opinion? |
|
@liggitt yeah we should try to keep the readme following best practices since it's probably something a lot of people will end up monkey-see-monkey-doing. |
|
@liggitt updated for comments. |
2aca180 to
d1704f6
Compare
|
LGTM, squash and merge |
d1704f6 to
3079d08
Compare
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1016/) (Image: devenv-fedora_869) |
|
Evaluated for origin up to 3079d08 |
Merged by openshift-bot
Updates to the sample app readme that add instructions for properly authorizing a user to see a project and make use of the new-project command.
/cc @smarterclayton @liggitt