Vagrantfile: default libvirt box now with actual openshift #1078
Conversation
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/976/) (Image: devenv-fedora_847) |
|
Evaluated for origin up to a082dc1 |
Merged by openshift-bot
|
@sosiouxme how does https://mirror.openshift.com/pub/vagrant/boxes/openshift3/fedora_libvirt_inst.box differ from https://mirror.openshift.com/pub/vagrant/boxes/openshift3/fedora_20_latest.box? Is it just created using vagrant-mutate on the VirtualBox box? I would like to see us add vagrant-mutate to our box creation, that way we can always reference the latest one using the same name for both of the providers. One issue that I ran into is that the vagrant-libvirt provider hardcodes the default storage pool as 'default' which caused me some pain, I wonder if it would be worth it to add a check to see if we can glean the storage pool info from the host (at least for local libvirt configs). There could very well be a similar issue with the networking, where the existing default network created interferes with an existing network (or has ip conflicts, etc). |
|
@detiber fedora_20_latest.box ... probably shouldn't really be there. I think @danmcp just wanted to keep the last f20 vbox around when switching to f21. fedora_libvirt_inst.box is just created with vagrant-mutate, yeah. The url need not correspond to the box name. Can use same box name with multiple providers, but not same box_url! You can modify the storage pool with storage_pool_name option (see https://github.com/pradels/vagrant-libvirt#provider-options) - would require modifying Vagrantfile. Having it look up the actual default instead of assuming "default" seems like the purview of vagrant-libvirt if you really want that. vagrant-libvirt also seems to create a new network "vagrant-libvirt" and corresponding device (which caused me some pain when the device actually already existed). Not sure if the options at https://github.com/pradels/vagrant-libvirt#provider-options are relevant there. |
|
@detiber @sosiouxme fedora_20_latest is still being used by the multi minion scenarios. The fedora21 image doesn't get along with the vagrant networking logic yet. |
…service-catalog/' changes from 8f07b7b..7e650e7 7e650e7 origin build: add origin tooling f32eec2 unit test for ./pkg/rest/core/fake rest client, addresses openshift#860 Test ready to be reviewed (openshift#1113) e388aee explicitly always prefer latest OSBAPI Version (openshift#1138) 962429e Merge branch 'pr/1135' b6ee7ef fix rbac cb1beb9 Merge branch 'pr/1131' ecc5c01 Update Code of Conduct (openshift#1137) e7c5ab3 address one more PR comment ddcbbad address PR comments 652a83b fix test expectation to match the new error message for missing service class 33417cc address PR comments 565fccf Use the chart name instead of the namespace (openshift#1102) bc61919 Add new terminal failure binding condition (openshift#1057) 4e642d5 Added more detailed instructions on how to setup the repo (openshift#1114) bdaea23 update unit tests (openshift#1123) 88a9642 validate the apiserver options (openshift#1116) b0af5fc fix whitespace in the copyright section dee796a generated type changes ef585c4 Rename the directory from default to defaultservicename to conform to go style guide. Wire admission controller into the apiserver 0b5d6c6 add firewall troubleshooting section (openshift#1040) fd9e6bc Fix Typo in Events Code of Conduct (openshift#1126) ebe6506 Fix Typo in Terminology (openshift#1128) 0038b1e Merge branch 'pr/1122' 8411f31 make deprovisioning an instance asynchronously not fall-through to synchronous deprovision (openshift#1067) 76c1d93 handle failures from list and test the not ready condition, cleanup 9241296 finish unit tests, passing ed75774 Minor fixes based on go report card 9911e8d Add GoReport Widget (openshift#1121) dd24e5c clean up old cruft 08276c6 generated file changes 6489d90 Implement the default plan in admission controller a6bb576 Code: Instance/Binding parameters from secret (openshift#1079) 10bb148 Update generated files (openshift#1115) 5291e6f v0.0.15 (openshift#1118) 28a1ea6 Merge branch 'pr/1104' bb4a2d2 Merge branch 'pr/1097' 1c14a90 push all arch images on release tags (openshift#1108) b587b2c Improve log output for deprovision 8887561 Remove PodPreset embedding from Binding (openshift#1030) 1abdcc8 Adjust helm/tiller installation instructions (openshift#1091) f636f99 only skip tls verify if not behind the aggregator (openshift#1101) 43b40ab controller_broker unit test bullet-proofing openshift#1077 (openshift#1099) bb596b8 Use data store instead of database (openshift#1100) 04fa477 Implementation: Support for Bearer token auth between Service Catalog and brokers (openshift#1053) 9e46d3c refactor Jenkins e2e tests (openshift#1082) 1f0a41e remove old/misleading comments about only doing soft delete if it's "our turn--" i.e. only if the finalizer we care about is at the head of the finalizers list. 5c1d9b8 Update OSB client (openshift#1085) a6e80ea Only do work for instances from a single queue (openshift#1074) 2bd85d6 Merge branch 'pr/1076' e324287 Tweaks to the walkthrough for local-up-cluster d8b7899 Add a note to the walkthrough about getting bindings when using the aggregator (openshift#1078) ea44cf1 msg on Environment Variables to set for e2e (openshift#1070) d15554a Merge branch 'pr/1017' faf966e Add comment re: async race condition in integration tests ed2e096 v0.0.14 (openshift#1071) fc84ffd more PR feedback 283bed4 Add integration tests and some error checking; PR feedback 903a7a7 Add terminal condition for instance and do not retry failed provisions REVERT: 8f07b7b origin: add required patches git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog git-subtree-split: 7e650e7e39c3fc79a8ecc061cce2a70e899406ff
4 participants
[merge]