add --timeout flag to oc rsh #10745
Merged
add --timeout flag to oc rsh #10745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
|
Needs to generate docs and completions. @liggitt PTAL |
juanvallejo
force-pushed
the
jvallejo_make-timeout-configurable-oc-rsh
branch
2 times, most recently
from
09e2bb1 to
bc6bb75
Compare
|
re[test] |
juanvallejo
force-pushed
the
jvallejo_make-timeout-configurable-oc-rsh
branch
from
bc6bb75 to
8d554f4
Compare
|
LGTM |
openshift-bot
added
the
needs-rebase
|
@fabianofranz PTAL |
`oc rsh` currently has a timeout of 10 seconds hardcoded for pod requests made to the server. This patch adds a flag `--timeout` to make this time user-configurable
juanvallejo
force-pushed
the
jvallejo_make-timeout-configurable-oc-rsh
branch
from
8d554f4 to
9ee734e
Compare
|
[merge] |
openshift-bot
removed
the
needs-rebase
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9286/) (Image: devenv-rhel7_5076) |
|
integration test flaked on #9203 |
|
conformance test flaked on #9548 re[test] |
|
Evaluated for origin test up to 9ee734e |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/9286/) |
|
re[merge] |
|
Evaluated for origin merge up to 9ee734e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oc rshcurrently has a timeout of 10 seconds hardcoded for podrequests made to the server. This patch adds a flag
--timeoutto makethis time user-configurable
cc @fabianofranz