Skip to content

make useLocalImages the default and remove configurability #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-bot merged 1 commit into from
Feb 19, 2015
Merged

make useLocalImages the default and remove configurability #1063

openshift-bot merged 1 commit into from
Feb 19, 2015

Conversation

@bparees
Copy link
Contributor

@bparees bparees commented Feb 18, 2015

all containers for deployment/build will now just use the k8s default "pullIfNotPresent" behavior and there will be no way to override the behavior (the USE_LOCAL_IMAGES env variable is removed)

@bparees
Copy link
Contributor Author

bparees commented Feb 18, 2015

@smarterclayton review please.

smarterclayton
smarterclayton reviewed Feb 18, 2015
View reviewed changes
pkg/cmd/server/start.go Outdated
Copy link
Contributor

@smarterclayton smarterclayton Feb 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't have anything to do with the previous section, keep it separate.

@smarterclayton
Copy link
Contributor

smarterclayton commented Feb 18, 2015

We should make it explicit we're setting pullIfNotPresent.

@smarterclayton
Copy link
Contributor

smarterclayton commented Feb 18, 2015

It's better to explicitly include it than rely on an upstream default.

@bparees
Copy link
Contributor Author

bparees commented Feb 18, 2015

@smarterclayton done.

@smarterclayton
Copy link
Contributor

smarterclayton commented Feb 18, 2015

LGTM, will merge after my change goes in.

@mfojtik
Copy link
Contributor

mfojtik commented Feb 18, 2015

thank you for this!
On Feb 18, 2015 7:24 PM, "Clayton Coleman" [email protected] wrote:

LGTM, will merge after my change goes in.

—
Reply to this email directly or view it on GitHub
#1063 (comment).

@smarterclayton
Copy link
Contributor

smarterclayton commented Feb 18, 2015

Will merge once #1054 goes in

@smarterclayton
Copy link
Contributor

smarterclayton commented Feb 19, 2015

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2015

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/970/) (Image: devenv-fedora_840)

@openshift-bot
Copy link
Contributor

openshift-bot commented Feb 19, 2015

Evaluated for origin up to b40fccb

openshift-bot pushed a commit that referenced this pull request Feb 19, 2015
Merge pull request #1063 from bparees/remove_local
e54750e 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit e54750e into openshift:master Feb 19, 2015
@bparees bparees deleted the remove_local branch February 19, 2015 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bparees @smarterclayton @mfojtik @openshift-bot