Turn on resource quota manager to collect usage stats #1047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekwaynecarr
changed the title
derekwaynecarr
force-pushed
the
turn_on_quota_controller
branch
from
7e6c063 to
bda0f0c
Compare
Contributor
There was a problem hiding this comment.
If this is slower, is that an issue?
Member
Author
There was a problem hiding this comment.
In current code, it affects two things at this time:
- If you add a ResourceQuota to a project, you will not be able to add resources in that project until the synch has been run.
- If you delete a resource, we only capture the delete until a synch has been run. If you are running at the edge of your quota, you will need to wait.
Right now, upstream it runs at 10s, but it is configurable in kube-controller-manager.
I have a card in the future to make the delete case less time-sensitive, basic idea would be to watch for delete events on pods, and update the related pod.Namespace quota to release that memory/cpu since that is probably most important.
Contributor
|
LGTM [merge] |
Contributor
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/957/) (Image: devenv-fedora_828) |
Member
|
unrelated failure [merge] |
Contributor
|
Evaluated for origin up to bda0f0c |
openshift-bot
pushed a commit
that referenced
this pull request
Feb 18, 2015
Merged by openshift-bot
sjenning
pushed a commit
to sjenning/origin
that referenced
this pull request
Jul 30, 2018
use version specific jenkins image in imagestream
wgahnagl
pushed a commit
to wgahnagl/origin
that referenced
this pull request
Oct 25, 2021
Fix: relative path will result infinite loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Origin all-in-one, we need to start the ResourceQuotaManager to collect usage stats against the quota in the background.
With this PR, you will be able to now see usage against your quota.
review please: @smarterclayton @jwforres