Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newImpersonatingRoundTripper needs to use current impersonation headers #18374

Closed
deads2k opened this issue Jan 31, 2018 · 1 comment
Closed

newImpersonatingRoundTripper needs to use current impersonation headers #18374

deads2k opened this issue Jan 31, 2018 · 1 comment
Assignees
@enj @simo5
Labels
priority/P1 sig/security
Milestone
v3.9

Comments

@deads2k
Copy link
Contributor

deads2k commented Jan 31, 2018

right now it is using the old "scopes" header, not the extra header.

/assign enj
/assign simo5

@openshift/sig-security
@deads2k deads2k added this to the 3.9.0 milestone Jan 31, 2018
@deads2k
Copy link
Contributor Author

deads2k commented Jan 31, 2018

Making a p1 for now. If we can fix this in 3.9, we have a shot at removing the debt in a release or two.

@simo5 simo5 mentioned this issue Jan 31, 2018
Merged
@deads2k deads2k mentioned this issue Feb 1, 2018
Closed
openshift-merge-robot added a commit that referenced this issue Feb 2, 2018
@openshift-merge-robot
Merge pull request #18378 from simo5/imprt
46c7fdd 
Automatic merge from submit-queue.

Change Header used for impersonation scopes

Fixes #18374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enj enj

@simo5 simo5

Labels
priority/P1 sig/security
Projects
None yet
Milestone
v3.9
Development

No branches or pull requests
4 participants
@enj @deads2k @simo5 @openshift-ci-robot