Skip to content

Conversation

@timflannagan
Copy link
Contributor

Merges the v0.10.0 upstream tag + individual cherry picks that need to be present downstream.

@openshift-ci openshift-ci bot requested review from exdx and tylerslaton September 12, 2022 14:05
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2022
Copy link

@exdx exdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: exdx, timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@timflannagan
Copy link
Contributor Author

We're still waiting to be introduced into the payload so adding the requisite labels until then.

/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Sep 12, 2022
@timflannagan
Copy link
Contributor Author

Just want to double check these changes on a clusterbot cluster.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2022
@timflannagan
Copy link
Contributor Author

Seeing this so far running the rukpak e2e suite on a local clusterbot cluster:

  initContainerStatuses:
  - image: quay.io/tflannag/rukpak:v0.11.0-tip
    imageID: ""
    lastState: {}
    name: install-unpacker
    ready: false
    restartCount: 0
    state:
      waiting:
        message: |
          container create failed: time="2022-09-12T14:32:40Z" level=error msg="runc create failed: unable to start container process: exec: \"cp\": executable file not found in $PATH"
        reason: CreateContainerError

Looks like the OCP base image no longer contains the "cp" executable?

@tylerslaton
Copy link
Contributor

@timflannagan Hm, that's weird. I checked in the container and it seems to contain the cp exectuable.

$ docker run -it registry.ci.openshift.org/ocp/4.12:base cp --version
cp (GNU coreutils) 8.30
Copyright (C) 2018 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Torbjorn Granlund, David MacKenzie, and Jim Meyering.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2022

@timflannagan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 99c7abb link false /test e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@timflannagan
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2022
@openshift-merge-robot openshift-merge-robot merged commit b6d70f3 into openshift:main Sep 12, 2022
@timflannagan timflannagan deleted the bump-v0.11.0-tip branch September 12, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants