-
Notifications
You must be signed in to change notification settings - Fork 19
Merge the upstream v0.10.0 rukpak tag #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge the upstream v0.10.0 rukpak tag #11
Conversation
Signed-off-by: timflannagan <[email protected]>
Signed-off-by: timflannagan <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
exdx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: exdx, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
We're still waiting to be introduced into the payload so adding the requisite labels until then. /label docs-approved |
|
Just want to double check these changes on a clusterbot cluster. /hold |
|
Seeing this so far running the rukpak e2e suite on a local clusterbot cluster: Looks like the OCP base image no longer contains the "cp" executable? |
|
@timflannagan Hm, that's weird. I checked in the container and it seems to contain the cp exectuable. |
|
@timflannagan: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold cancel |
Merges the v0.10.0 upstream tag + individual cherry picks that need to be present downstream.