Skip to content

Conversation

@perdasilva
Copy link
Contributor

Description

Because of changes to the hashing algorithm that identifies manifests that need to be applied during install / upgrade, the unpack steps for bundles that have been installed using the old hashing algorithm cannot be found as they have a different name.

This code reintroduces the legacy hashing algorithm to resolve only objects that have been installed using this legacy process so they are not stranded. It adds the legacy steps to the map of steps. If the install was made using the new algorithm, these olds steps are unused. If the install was made using the old algorithm, the new steps are unused.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 10, 2025
@openshift-ci-robot
Copy link

@perdasilva: This pull request references Jira Issue OCPBUGS-32262, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Description

Because of changes to the hashing algorithm that identifies manifests that need to be applied during install / upgrade, the unpack steps for bundles that have been installed using the old hashing algorithm cannot be found as they have a different name.

This code reintroduces the legacy hashing algorithm to resolve only objects that have been installed using this legacy process so they are not stranded. It adds the legacy steps to the map of steps. If the install was made using the new algorithm, these olds steps are unused. If the install was made using the old algorithm, the new steps are unused.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2025
@perdasilva perdasilva changed the title OCPBUGS-32262: couldn''t find unpacked step OCPBUGS-32262: couldn't find unpacked step Mar 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2025

@perdasilva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-olm 56092cd link true /test e2e-gcp-olm
ci/prow/verify 56092cd link true /test verify
ci/prow/e2e-gcp-console-olm 56092cd link true /test e2e-gcp-console-olm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@perdasilva perdasilva closed this Mar 10, 2025
@openshift-ci-robot
Copy link

@perdasilva: This pull request references Jira Issue OCPBUGS-32262. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Description

Because of changes to the hashing algorithm that identifies manifests that need to be applied during install / upgrade, the unpack steps for bundles that have been installed using the old hashing algorithm cannot be found as they have a different name.

This code reintroduces the legacy hashing algorithm to resolve only objects that have been installed using this legacy process so they are not stranded. It adds the legacy steps to the map of steps. If the install was made using the new algorithm, these olds steps are unused. If the install was made using the old algorithm, the new steps are unused.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants