Skip to content

[release-4.16] OCPBUGS-48696: Fix excessive catalog source snapshots cause severe performance regression#954

Closed
oceanc80 wants to merge 2 commits intoopenshift:release-4.16from
oceanc80:catperf-4.16
Closed

[release-4.16] OCPBUGS-48696: Fix excessive catalog source snapshots cause severe performance regression#954
oceanc80 wants to merge 2 commits intoopenshift:release-4.16from
oceanc80:catperf-4.16

Conversation

@oceanc80
Copy link
Copy Markdown
Contributor

@oceanc80 oceanc80 commented Jan 22, 2025

This is a manual cherry-pick of #937

@joelanford @oceanc80
🐛 use operator cache provider for deprecation updates to limit calls …
1c7c66a 
…to GRPC server (#3490)

* add log and metric to instrument count of catalog source snapshots

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* use operator cache provider for deprecation updates to limit calls to GRPC server

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

---------

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 1274d54d885649786733d0b3fe499e9670f3310d
@joelanford @oceanc80
sort lists of identifiers and conflict messages to reduce SAT solver …
1650091 
…non-determinism (#3491)

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 451e775ea03eb9280399ba0abaf19bd237df167c
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 22, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 22, 2025

@oceanc80: This pull request references Jira Issue OCPBUGS-48696, which is invalid:

  • expected dependent Jira Issue OCPBUGS-48695 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual cherry-pick of #937

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@oceanc80
Copy link
Copy Markdown
Contributor Author

oceanc80 commented Jan 22, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 22, 2025
@openshift-ci openshift-ci Bot requested review from perdasilva and tmshort January 22, 2025 04:16
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oceanc80

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 22, 2025

@oceanc80: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 1650091 link true /test images
ci/prow/e2e-gcp-ovn 1650091 link true /test e2e-gcp-ovn
ci/prow/e2e-upgrade 1650091 link true /test e2e-upgrade
ci/prow/unit-olm 1650091 link true /test unit-olm
ci/prow/e2e-gcp-olm-flaky 1650091 link false /test e2e-gcp-olm-flaky
ci/prow/e2e-gcp-olm 1650091 link true /test e2e-gcp-olm
ci/prow/periodics-images 1650091 link true /test periodics-images
ci/prow/e2e-gcp-console-olm 1650091 link true /test e2e-gcp-console-olm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Jan 22, 2025

fixed up in #957

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Jan 22, 2025

/close

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 22, 2025
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Jan 22, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot closed this Jan 22, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 22, 2025

@perdasilva: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 22, 2025

@oceanc80: This pull request references Jira Issue OCPBUGS-48696. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual cherry-pick of #937

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perdasilva perdasilva Awaiting requested review from perdasilva

@tmshort tmshort Awaiting requested review from tmshort

Assignees

@bandrade bandrade

@jianzhangbjz jianzhangbjz

@emmajiafan emmajiafan

@kuiwang02 kuiwang02

@Xia-Zhao-rh Xia-Zhao-rh

@KeenonLee KeenonLee

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.