Skip to content

[WIP][release-4.14] OCPBUGS-48663: Fix concurrent namespace resolution#949

Closed
perdasilva wants to merge 4 commits intoopenshift:release-4.14from
perdasilva:workqueue-fix-414
Closed

[WIP][release-4.14] OCPBUGS-48663: Fix concurrent namespace resolution#949
perdasilva wants to merge 4 commits intoopenshift:release-4.14from
perdasilva:workqueue-fix-414

Conversation

@perdasilva
Copy link
Copy Markdown
Contributor

@perdasilva perdasilva commented Jan 21, 2025

This is a manual cherry-pick of #948

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025
@perdasilva perdasilva changed the title [release-4.14] OCPBUGS-XXXXX: Fix concurrent namespace resolution [release-4.14] OCPBUGS-48663: Fix concurrent namespace resolution Jan 21, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 21, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 21, 2025

@perdasilva: This pull request references Jira Issue OCPBUGS-48663, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-48662 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual cherry-pick of #948

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@perdasilva
Copy link
Copy Markdown
Contributor Author

perdasilva commented Jan 21, 2025

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 21, 2025

@perdasilva: This pull request references Jira Issue OCPBUGS-48663, which is invalid:

  • expected dependent Jira Issue OCPBUGS-48662 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

joelanford and others added 3 commits January 21, 2025 10:31
@joelanford
🐛 Switch queue informer to use types.Namespace name; relocate deletio…
4fb82db 
…n handler (#3483)

* switch queue informer to use types.NamespacedName; relocate deletion handler

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

* Add error message to object count assertion failure

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

---------

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: edb751b9718ffe29e8462ce17867ec3db3b349ff
[CARRY] fixup ns labeler plugin
8079389 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
[CARRY] address lint issues in namespace labeler plugin
10e0bf9 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva
Copy link
Copy Markdown
Contributor Author

perdasilva commented Jan 21, 2025

/retest

@perdasilva perdasilva force-pushed the workqueue-fix-414 branch 2 times, most recently from 17529de to b1578df Compare January 21, 2025 16:44
@perdasilva perdasilva changed the title [release-4.14] OCPBUGS-48663: Fix concurrent namespace resolution [WIP][release-4.14] OCPBUGS-48663: Fix concurrent namespace resolution Jan 21, 2025
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2025
@perdasilva
Copy link
Copy Markdown
Contributor Author

perdasilva commented Jan 22, 2025

/retest

1 similar comment
@perdasilva
Copy link
Copy Markdown
Contributor Author

perdasilva commented Jan 22, 2025

/retest

@kuiwang02
Copy link
Copy Markdown
Contributor

kuiwang02 commented Jan 23, 2025

/label cherry-pick-approved
/label qe-approved

@openshift-ci openshift-ci Bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Jan 23, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 23, 2025

@perdasilva: This pull request references Jira Issue OCPBUGS-48663, which is invalid:

  • expected dependent Jira Issue OCPBUGS-48662 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual cherry-pick of #948

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[CARRY] address gc queue problem
a9dfa79 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 29, 2025

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 30, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 30, 2025
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 2, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@perdasilva
Copy link
Copy Markdown
Contributor Author

perdasilva commented May 5, 2025

no longer required by the SRE team

@perdasilva perdasilva closed this May 5, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 5, 2025

@perdasilva: This pull request references Jira Issue OCPBUGS-48663. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

This is a manual cherry-pick of #948

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@perdasilva @openshift-ci-robot @kuiwang02 @openshift-bot @joelanford