[release-4.17] OCPBUGS-45845: Fix concurrent namespace resolution by perdasilva · Pull Request #944 · openshift/operator-framework-olm

perdasilva · 2025-01-20T13:41:25Z

This is a manual cherry-pick of #946

…n handler (#3483) * switch queue informer to use types.NamespacedName; relocate deletion handler Signed-off-by: Joe Lanford <joe.lanford@gmail.com> * Add error message to object count assertion failure Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> --------- Signed-off-by: Joe Lanford <joe.lanford@gmail.com> Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com> Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com> Upstream-repository: operator-lifecycle-manager Upstream-commit: edb751b9718ffe29e8462ce17867ec3db3b349ff

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

openshift-ci · 2025-01-20T13:41:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~DOWNSTREAM_OWNERS~~ [perdasilva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

openshift-ci-robot · 2025-01-20T13:55:29Z

@perdasilva: This pull request references Jira Issue OCPBUGS-45845, which is invalid:

expected the bug to target the "4.17.z" version, but no target version was set
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-45845 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

perdasilva · 2025-01-20T15:56:00Z

/retest

perdasilva · 2025-01-20T19:21:23Z

/retest

openshift-ci-robot · 2025-01-20T19:23:49Z

@perdasilva: This pull request references Jira Issue OCPBUGS-45845. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

Details

In response to this:

cherry-picks the fixes in #936 and adjusts them for the fact that the vendored client-go does not yet used Typed interfaces yet. Adds a panic in case the workqueue item is not a NamespacedName

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-01-20T19:24:21Z

@perdasilva: This pull request references Jira Issue OCPBUGS-45845, which is invalid:

expected the bug to target the "4.17.z" version, but no target version was set
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-45845 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

cherry-picks the fixes in #936 and adjusts them for the fact that the vendored client-go does not yet used Typed interfaces yet. Adds a panic in case the workqueue item is not a NamespacedName

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

perdasilva · 2025-01-20T19:24:23Z

/jira refresh

openshift-ci-robot · 2025-01-20T19:24:27Z

@perdasilva: This pull request references Jira Issue OCPBUGS-45845, which is invalid:

expected the bug to target the "4.17.z" version, but no target version was set
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-45845 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-01-21T07:55:21Z

@perdasilva: This pull request references Jira Issue OCPBUGS-45845, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-48486 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
expected dependent Jira Issue OCPBUGS-48486 to target a version in 4.18.0, but it targets "4.19.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual cherry-pick of #946

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

perdasilva · 2025-01-21T09:07:57Z

/jira refresh

openshift-ci-robot · 2025-01-21T09:08:01Z

@perdasilva: This pull request references Jira Issue OCPBUGS-45845, which is invalid:

expected dependent Jira Issue OCPBUGS-48660 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead
expected dependent Jira Issue OCPBUGS-48660 to target a version in 4.18.0, but it targets "4.18.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kuiwang02 · 2025-01-21T10:05:50Z

/jira refresh

openshift-ci-robot · 2025-01-21T10:05:54Z

@kuiwang02: This pull request references Jira Issue OCPBUGS-45845, which is invalid:

expected dependent Jira Issue OCPBUGS-48660 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

perdasilva · 2025-01-21T13:21:10Z

/jira refresh

openshift-ci-robot · 2025-01-21T13:21:14Z

@perdasilva: This pull request references Jira Issue OCPBUGS-45845, which is invalid:

expected dependent Jira Issue OCPBUGS-48660 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

joelanford · 2025-01-21T13:59:34Z

/label backport-risk-assessed
/lgtm

kuiwang02 · 2025-01-22T04:17:53Z

/label cherry-pick-approved
/label qe-approved

openshift-ci-robot · 2025-01-22T04:18:03Z

@perdasilva: This pull request references Jira Issue OCPBUGS-45845, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.17.z) matches configured target version for branch (4.17.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-48660 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-48660 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
bug has dependents

Requesting review from QA contact:
/cc @kuiwang02

Details

In response to this:

This is a manual cherry-pick of #946

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-01-22T07:42:34Z

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-01-22T07:45:09Z

@perdasilva: Jira Issue OCPBUGS-45845: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#944

Jira Issue OCPBUGS-45845 has been moved to the MODIFIED state.

Details

In response to this:

This is a manual cherry-pick of #946

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2025-01-22T09:02:56Z

[ART PR BUILD NOTIFIER]

Distgit: operator-lifecycle-manager
This PR has been included in build operator-lifecycle-manager-container-v4.17.0-202501220804.p0.gd39d739.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2025-01-22T09:03:01Z

[ART PR BUILD NOTIFIER]

Distgit: operator-registry
This PR has been included in build operator-registry-container-v4.17.0-202501220804.p0.gd39d739.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2025-01-22T09:05:58Z

[ART PR BUILD NOTIFIER]

Distgit: ose-operator-framework-tools
This PR has been included in build ose-operator-framework-tools-container-v4.17.0-202501220804.p0.gd39d739.assembly.stream.el9.
All builds following this will include this PR.

joelanford and others added 2 commits January 20, 2025 14:36

[CARRY] fixup ns labeler plugin

1efcd95

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2025

openshift-ci Bot requested review from anik120 and oceanc80 January 20, 2025 13:41

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025

[CARRY] address lint issues in namespace labeler plugin

9faf896

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

perdasilva changed the title ~~[WIP] workqueue fix [release-4.17]~~ OCPBUGS-45845: workqueue fix [release-4.17] Jan 20, 2025

openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jan 20, 2025

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 20, 2025

perdasilva changed the title ~~OCPBUGS-45845: workqueue fix [release-4.17]~~ OCPBUGS-45845: Fix concurrent namespace resolution [release-4.17] Jan 20, 2025

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2025

perdasilva closed this Jan 20, 2025

perdasilva reopened this Jan 20, 2025

perdasilva changed the title ~~OCPBUGS-45845: Fix concurrent namespace resolution [release-4.17]~~ [release-4.17] OCPBUGS-45845: Fix concurrent namespace resolution Jan 20, 2025

perdasilva mentioned this pull request Jan 21, 2025

[release-4.16] OCPBUGS-48661: Fix concurrent namespace resolution #947

Merged

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 21, 2025

openshift-ci Bot assigned bandrade, emmajiafan, jianzhangbjz, KeenonLee, kuiwang02, Xia-Zhao-rh and joelanford Jan 21, 2025

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2025

openshift-ci Bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Jan 22, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 22, 2025

openshift-ci Bot requested a review from kuiwang02 January 22, 2025 04:18

openshift-merge-bot Bot merged commit d39d739 into openshift:release-4.17 Jan 22, 2025

Conversation

perdasilva commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Jan 20, 2025

Uh oh!

openshift-ci-robot commented Jan 20, 2025

Uh oh!

perdasilva commented Jan 20, 2025

Uh oh!

perdasilva commented Jan 20, 2025

Uh oh!

openshift-ci-robot commented Jan 20, 2025

Uh oh!

openshift-ci-robot commented Jan 20, 2025

Uh oh!

perdasilva commented Jan 20, 2025

Uh oh!

openshift-ci-robot commented Jan 20, 2025

Uh oh!

openshift-ci-robot commented Jan 21, 2025

Uh oh!

perdasilva commented Jan 21, 2025

Uh oh!

openshift-ci-robot commented Jan 21, 2025

Uh oh!

kuiwang02 commented Jan 21, 2025

Uh oh!

openshift-ci-robot commented Jan 21, 2025

Uh oh!

perdasilva commented Jan 21, 2025

Uh oh!

openshift-ci-robot commented Jan 21, 2025

Uh oh!

joelanford commented Jan 21, 2025

Uh oh!

kuiwang02 commented Jan 22, 2025

Uh oh!

openshift-ci-robot commented Jan 22, 2025

Uh oh!

openshift-ci Bot commented Jan 22, 2025

Uh oh!

openshift-ci-robot commented Jan 22, 2025

Uh oh!

openshift-bot commented Jan 22, 2025

Uh oh!

openshift-bot commented Jan 22, 2025

Uh oh!

openshift-bot commented Jan 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

perdasilva commented Jan 20, 2025 •

edited

Loading