Skip to content

Fix pop candidate script#464

Closed
perdasilva wants to merge 2 commits intoopenshift:masterfrom
perdasilva:fix_pop_candidate_script
Closed

Fix pop candidate script#464
perdasilva wants to merge 2 commits intoopenshift:masterfrom
perdasilva:fix_pop_candidate_script

Conversation

@perdasilva
Copy link
Copy Markdown
Contributor

@perdasilva perdasilva commented Mar 7, 2023

The pop_candidate_script wasn't handling the command line flags (-a) properly, which was causing the script to fail.

rashmigottipati and others added 2 commits March 7, 2023 09:59
@rashmigottipati @perdasilva
OPECO-2646: exclude bundles with olm.deprecated property when rende…
a9efb9e 
…ring (openshift#1063)

* exclude bundles with `olm.deprecated` property when rendering

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

* Exclude bundles based on the property type and not value

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>

---------

Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
Upstream-repository: operator-registry
Upstream-commit: 0aeffa3f44f5e36bd2c0bcc63a94eda000a5f257
@perdasilva
fix pop_candidate script
f06255a 
Signed-off-by: perdasilva <perdasilva@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 7, 2023

@perdasilva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-olm f06255a link true /test e2e-gcp-olm
ci/prow/unit-olm f06255a link true /test unit-olm
ci/prow/verify f06255a link true /test verify
ci/prow/e2e-upgrade f06255a link true /test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@perdasilva perdasilva closed this Mar 7, 2023
@openshift-bot openshift-bot mentioned this pull request Jan 24, 2026
Merged
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Jan 24, 2026
@tmshort
Update to golang 1.25 (openshift#464)
f9dfb35 
Signed-off-by: Todd Short <todd.short@me.com>
Upstream-repository: api
Upstream-commit: dfd6338259ef76484d7b64e408e4542e72744d6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@joelanford joelanford Awaiting requested review from joelanford

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@perdasilva @rashmigottipati