Skip to content

OCPBUGS-7431: Registry Pod Controller Flag #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 27, 2023
Merged

OCPBUGS-7431: Registry Pod Controller Flag #460

openshift-merge-robot merged 1 commit into from
Mar 27, 2023

Conversation

@dtfranz
Copy link
Contributor

@dtfranz dtfranz commented Feb 23, 2023 •
edited
Loading

Sets the controller flag on the registry pod owner references to true to remove the need for forceful shutdown when draining nodes.

Motivation for change:
OCPBUGS-7431

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dtfranz
Registry Pod Controller Flag (#2928)
b19ae97 
Sets the marketplace pod's ownerreference to have `controller: true` to remove need for forceful node drain.

Upstream-repository: operator-lifecycle-manager
Upstream-commit: e5da837

Signed-off-by: Daniel Franz <[email protected]>
@dtfranz dtfranz force-pushed the registry-pod-owner-controller branch from 771d5f0 to b19ae97 Compare March 15, 2023 16:38
@dtfranz
Copy link
Contributor Author

dtfranz commented Mar 15, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2023
@dtfranz dtfranz marked this pull request as ready for review March 15, 2023 16:39
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2023
@dtfranz dtfranz changed the title Registry Pod Controller Flag OCPBUGS-7431: Registry Pod Controller Flag Mar 15, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 15, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 15, 2023

@dtfranz: This pull request references Jira Issue OCPBUGS-7431, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Draft PR for use with cluster bot, not ready for QA/Review/Etc.

Sets the controller flag on the registry pod owner references to true in an attempt to remove the need for forceful shutdown when draining nodes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 15, 2023

@dtfranz: This pull request references Jira Issue OCPBUGS-7431, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Sets the controller flag on the registry pod owner references to true in an attempt to remove the need for forceful shutdown when draining nodes.

Motivation for change:
OCPBUGS-7431

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtfranz
Copy link
Contributor Author

dtfranz commented Mar 15, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 15, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 15, 2023

@dtfranz: This pull request references Jira Issue OCPBUGS-7431, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jianzhangbjz March 15, 2023 16:42
@jianzhangbjz
Copy link
Member

jianzhangbjz commented Mar 16, 2023

Test passed, details: https://issues.redhat.com/browse/OCPBUGS-7431
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 16, 2023
@dtfranz
Copy link
Contributor Author

dtfranz commented Mar 23, 2023

/retest

2 similar comments
@dtfranz
Copy link
Contributor Author

dtfranz commented Mar 23, 2023

/retest

@dtfranz
Copy link
Contributor Author

dtfranz commented Mar 24, 2023

/retest

@grokspawn
Copy link
Contributor

grokspawn commented Mar 24, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtfranz, grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 24, 2023

@dtfranz: This pull request references Jira Issue OCPBUGS-7431, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

Sets the controller flag on the registry pod owner references to true to remove the need for forceful shutdown when draining nodes.

Motivation for change:
OCPBUGS-7431

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva
Copy link
Contributor

perdasilva commented Mar 24, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2023
@dtfranz
Copy link
Contributor Author

dtfranz commented Mar 24, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 24, 2023

/retest-required

Remaining retests: 0 against base HEAD 440894b and 2 for PR HEAD b19ae97 in total

@dtfranz
Copy link
Contributor Author

dtfranz commented Mar 24, 2023

/retest

1 similar comment
@dtfranz
Copy link
Contributor Author

dtfranz commented Mar 27, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 27, 2023

@dtfranz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 6ca5476 into openshift:master Mar 27, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2023

@dtfranz: Jira Issue OCPBUGS-7431: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-7431 has been moved to the MODIFIED state.

Details

In response to this:

Sets the controller flag on the registry pod owner references to true to remove the need for forceful shutdown when draining nodes.

Motivation for change:
OCPBUGS-7431

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtfranz
Copy link
Contributor Author

dtfranz commented Jan 25, 2024

/cherry-pick release-4.13

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 25, 2024

@dtfranz: new pull request created: #672

Details

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 25, 2024
Merged
@dtfranz
Copy link
Contributor Author

dtfranz commented Jan 25, 2024

/cherry-pick release-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 25, 2024
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 25, 2024

@dtfranz: new pull request created: #673

Details

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot openshift-bot mentioned this pull request Dec 18, 2025
Merged
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Dec 18, 2025
@dependabot
Bump github.com/spf13/cobra from 1.10.1 to 1.10.2 (openshift#460)
44ab9ec 
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.10.1 to 1.10.2.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.10.1...v1.10.2)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-version: 1.10.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: 4efa173a0e0ee75104a91d8abaa61e46bd370e53
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Dec 19, 2025
@dependabot
Bump github.com/spf13/cobra from 1.10.1 to 1.10.2 (openshift#460)
81b13d6 
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.10.1 to 1.10.2.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.10.1...v1.10.2)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-version: 1.10.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: 4efa173a0e0ee75104a91d8abaa61e46bd370e53
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Dec 20, 2025
@dependabot
Bump github.com/spf13/cobra from 1.10.1 to 1.10.2 (openshift#460)
f26e4fd 
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.10.1 to 1.10.2.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.10.1...v1.10.2)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-version: 1.10.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: 4efa173a0e0ee75104a91d8abaa61e46bd370e53
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Dec 25, 2025
@dependabot
Bump github.com/spf13/cobra from 1.10.1 to 1.10.2 (openshift#460)
15f6d1c 
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.10.1 to 1.10.2.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.10.1...v1.10.2)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-version: 1.10.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: 4efa173a0e0ee75104a91d8abaa61e46bd370e53
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Jan 1, 2026
@dependabot
Bump github.com/spf13/cobra from 1.10.1 to 1.10.2 (openshift#460)
9e71a0c 
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.10.1 to 1.10.2.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.10.1...v1.10.2)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-version: 1.10.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upstream-repository: api
Upstream-commit: 4efa173a0e0ee75104a91d8abaa61e46bd370e53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awgreene awgreene Awaiting requested review from awgreene

@gallettilance gallettilance Awaiting requested review from gallettilance

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

Assignees

@perdasilva perdasilva

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dtfranz @openshift-ci-robot @jianzhangbjz @grokspawn @perdasilva @openshift-cherrypick-robot @openshift-merge-robot