Skip to content

Thread Safety test for UpdateSubsSyncCounterStorage (#2918) #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 6, 2023
Merged

Thread Safety test for UpdateSubsSyncCounterStorage (#2918) #438

openshift-merge-robot merged 1 commit into from
Feb 6, 2023

Conversation

@awgreene
Copy link
Contributor

@awgreene awgreene commented Feb 2, 2023

Introduces a test that ensure that the UpdateSubsSyncCounterStorage function is thread safe and avoids concurrent map writes.

Signed-off-by: Alexander Greene greene.al1991@gmail.com

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 84ab8d27288ae40d92bdf7f58ebec537f8b187fc

@awgreene
Thread Safety test for UpdateSubsSyncCounterStorage (#2918)
ed4444c 
Introduces a test that ensure that the UpdateSubsSyncCounterStorage
function is thread safe and avoids concurrent map writes.

Signed-off-by: Alexander Greene <greene.al1991@gmail.com>

Upstream-repository: operator-lifecycle-manager
Upstream-commit: 84ab8d27288ae40d92bdf7f58ebec537f8b187fc
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2023
@dtfranz
Copy link
Contributor

dtfranz commented Feb 2, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2023
@awgreene
Copy link
Contributor Author

awgreene commented Feb 3, 2023

/retest

@awgreene
Copy link
Contributor Author

awgreene commented Feb 3, 2023

This is just a unit test backport, so I'm gonna save the qe/px/docs team some time.
/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Feb 3, 2023
@awgreene
Copy link
Contributor Author

awgreene commented Feb 3, 2023

/test e2e-gcp-ovn

@awgreene
Copy link
Contributor Author

awgreene commented Feb 3, 2023

/retest

@awgreene awgreene mentioned this pull request Feb 3, 2023
Closed
@awgreene
Copy link
Contributor Author

awgreene commented Feb 3, 2023

/retest
Cluster failed to launch

@awgreene
Copy link
Contributor Author

awgreene commented Feb 3, 2023

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 4, 2023

/retest-required

Remaining retests: 0 against base HEAD 0c03a71 and 2 for PR HEAD ed4444c in total

@awgreene
Copy link
Contributor Author

awgreene commented Feb 4, 2023

/retest

1 similar comment
@perdasilva
Copy link
Contributor

perdasilva commented Feb 6, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2023

@awgreene: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7ec6b94 into openshift:master Feb 6, 2023
openshift-bot pushed a commit to openshift-bot/operator-framework-olm that referenced this pull request Aug 14, 2025
@grokspawn
normalize unit test targets across repos. add skip/target test args (o…
087e6c9 
…penshift#438)

Signed-off-by: grokspawn <jordan@nimblewidget.com>
Upstream-repository: api
Upstream-commit: d6a691fa17280bfc5f17e22e73edb6fcd0b64503
@openshift-bot openshift-bot mentioned this pull request Aug 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anik120 anik120 Awaiting requested review from anik120

@gallettilance gallettilance Awaiting requested review from gallettilance

Assignees

@dtfranz dtfranz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@awgreene @dtfranz @openshift-ci-robot @perdasilva @openshift-merge-robot