Ensure that the $ARTIFACTS_DIR variable is respected #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: timflannagan <timflannagan@gmail.com>
This directory is populating when the e2e suite is supplied with an output $ARTIFACTS_DIR, and the script that's responsible for gathering CI testing artifacts when a test case fails. Signed-off-by: timflannagan <timflannagan@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Signed-off-by: perdasilva <perdasilva@redhat.com>
Signed-off-by: perdasilva <perdasilva@redhat.com>
Signed-off-by: perdasilva <perdasilva@redhat.com>
Signed-off-by: perdasilva <perdasilva@redhat.com>
Signed-off-by: perdasilva <perdasilva@redhat.com>
…aming (#2715) * Add importas linting configuration to enforce common package import naming Signed-off-by: timflannagan <timflannagan@gmail.com> * cmd,pkg,test: Fix linting violations Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: perdasilva <perdasilva@redhat.com>
Signed-off-by: perdasilva <perdasilva@redhat.com>
Signed-off-by: perdasilva <perdasilva@redhat.com>
Contributor
Author
|
/retest-required |
Signed-off-by: perdasilva <perdasilva@redhat.com> Signed-off-by: timflannagan <timflannagan@gmail.com>
Contributor
Author
|
/test ci/prow/e2e-gcp-olm |
Contributor
|
@timflannagan: The specified target(s) for
The following commands are available to trigger optional jobs:
Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Contributor
Author
|
/test e2e-gcp-olm |
Contributor
Author
|
Looks like we may need some downstream-only changes to handle injecting the $ARTIFACTS_DIR variable. |
Contributor
Author
|
Holding after the latest comment. /hold |
openshift-ci
bot
added
the
do-not-merge/hold
Contributor
Author
|
/retest-required |
Contributor
|
@timflannagan: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-rebase
Contributor
|
@timflannagan: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
awgreene
added a commit
to awgreene/operator-framework-olm
that referenced
this pull request
Dec 10, 2022
The catalogSource api was recently updated to support running the associated pod in a "restricted" workflow as defined by the Pod Security Admission controller. By default, the catalogSource pods have been configured to run in "restricted" mode, which is disruptive to customers managing and deploying their own catalogSources as they need to rebuild their catalogs to run in "restricted" mode if a namespace is marked as "restricted". In an effort to provide users with a bit more time to rebuilt their catalogSources, this change configures catalogSources to run in "legacy" mode by default. A series of other changes will be made to update the namespaces associated with marketplace and olm to support catalogSources running in "legacy" mode by default. Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
awgreene
added a commit
to awgreene/operator-framework-olm
that referenced
this pull request
Dec 12, 2022
The catalogSource api was recently updated to support running the associated pod in a "restricted" workflow as defined by the Pod Security Admission controller. By default, the catalogSource pods have been configured to run in "restricted" mode, which is disruptive to customers managing and deploying their own catalogSources as they need to rebuild their catalogs to run in "restricted" mode if a namespace is marked as "restricted". In an effort to provide users with a bit more time to rebuilt their catalogSources, this change configures catalogSources to run in "legacy" mode by default. A series of other changes will be made to update the namespaces associated with marketplace and olm to support catalogSources running in "legacy" mode by default. Signed-off-by: Alexander Greene <greene.al1991@gmail.com>
awgreene
added a commit
to awgreene/operator-framework-olm
that referenced
this pull request
Dec 13, 2022
The catalogSource api was recently updated to support running the associated pod in a "restricted" workflow as defined by the Pod Security Admission controller. By default, the catalogSource pods have been configured to run in "restricted" mode, which is disruptive to customers managing and deploying their own catalogSources as they need to rebuild their catalogs to run in "restricted" mode if a namespace is marked as "restricted". In an effort to provide users with a bit more time to rebuilt their catalogSources, this change configures catalogSources to run in "legacy" mode by default. A series of other changes will be made to update the namespaces associated with marketplace and olm to support catalogSources running in "legacy" mode by default. Signed-off-by: Alexander Greene <greene.al1991@gmail.com> Upstream-repository: api Upstream-commit: 9fe16de3fd69800828decd67cf41ba9c5c773106
awgreene
added a commit
to awgreene/operator-framework-olm
that referenced
this pull request
Dec 14, 2022
The catalogSource api was recently updated to support running the associated pod in a "restricted" workflow as defined by the Pod Security Admission controller. By default, the catalogSource pods have been configured to run in "restricted" mode, which is disruptive to customers managing and deploying their own catalogSources as they need to rebuild their catalogs to run in "restricted" mode if a namespace is marked as "restricted". In an effort to provide users with a bit more time to rebuilt their catalogSources, this change configures catalogSources to run in "legacy" mode by default. A series of other changes will be made to update the namespaces associated with marketplace and olm to support catalogSources running in "legacy" mode by default. Signed-off-by: Alexander Greene <greene.al1991@gmail.com> Upstream-repository: api Upstream-commit: 9fe16de3fd69800828decd67cf41ba9c5c773106
awgreene
added a commit
to awgreene/operator-framework-olm
that referenced
this pull request
Dec 15, 2022
The catalogSource api was recently updated to support running the associated pod in a "restricted" workflow as defined by the Pod Security Admission controller. By default, the catalogSource pods have been configured to run in "restricted" mode, which is disruptive to customers managing and deploying their own catalogSources as they need to rebuild their catalogs to run in "restricted" mode if a namespace is marked as "restricted". In an effort to provide users with a bit more time to rebuilt their catalogSources, this change configures catalogSources to run in "legacy" mode by default. A series of other changes will be made to update the namespaces associated with marketplace and olm to support catalogSources running in "legacy" mode by default. Signed-off-by: Alexander Greene <greene.al1991@gmail.com> Upstream-repository: api Upstream-commit: 9fe16de3fd69800828decd67cf41ba9c5c773106
openshift-merge-robot
added a commit
that referenced
this pull request
Dec 20, 2022
OCPBUGS-4757: Default to legacy psa settings (#273)
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/operator-framework-olm
that referenced
this pull request
Dec 20, 2022
The catalogSource api was recently updated to support running the associated pod in a "restricted" workflow as defined by the Pod Security Admission controller. By default, the catalogSource pods have been configured to run in "restricted" mode, which is disruptive to customers managing and deploying their own catalogSources as they need to rebuild their catalogs to run in "restricted" mode if a namespace is marked as "restricted". In an effort to provide users with a bit more time to rebuilt their catalogSources, this change configures catalogSources to run in "legacy" mode by default. A series of other changes will be made to update the namespaces associated with marketplace and olm to support catalogSources running in "legacy" mode by default. Signed-off-by: Alexander Greene <greene.al1991@gmail.com> Upstream-repository: api Upstream-commit: 9fe16de3fd69800828decd67cf41ba9c5c773106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure the
make e2e/olm ARTIFACTS_DIR=...works when running the upstream OLM e2e suite in downstream CI environments.