Bug 2037168: Remove incorrect cvo annotations #238

kevinrizza · 2022-01-05T15:38:00Z

The single-node-developer profile was ultimately not implemented, and as
a result is ultimately unnecessary. This commit removes it from all
manifests
see openshift/cluster-version-operator#685

Additionally, the ibm-cloud-managed annotation and self-managed
annotations are applied to both versions of the psm deployment manifest.
Since these are in conflict, in the future they could potentially cause
flapping by the CVO to apply both versions of the manifest to the
cluster.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2037168

The single-node-developer profile was ultimately not implemented, and as a result is ultimately unnecessary. This commit removes it from all manifests see openshift/cluster-version-operator#685 Additionally, the ibm-cloud-managed annotation and self-managed annotations are applied to both versions of the psm deployment manifest. Since these are in conflict, in the future they could potentially cause flapping by the CVO to apply both versions of the manifest to the cluster. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2037168

openshift-ci · 2022-01-05T15:38:04Z

@kevinrizza: This pull request references Bugzilla bug 2037168, which is invalid:

expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 2037168: Remove incorrect cvo annotations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kevinrizza · 2022-01-05T15:38:34Z

/bugzilla refresh

openshift-ci · 2022-01-05T15:38:42Z

@kevinrizza: This pull request references Bugzilla bug 2037168, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.10.0) matches configured target release for branch (4.10.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

timflannagan · 2022-01-05T15:41:32Z

scripts/generate_crds_manifests.sh

  labels:
    app: package-server-manager
  annotations:
-    include.release.openshift.io/self-managed-high-availability: "true"


Why was this annotation removed as well?

Because they're opposite profiles. The self managed profile (the default cvo profile) shouldn't apply to the manifests that are specifically just for the ibm manifests. Take a look at our other deployment manifests that specifically include them, this change just makes those match.

For the manifests where we just have one copy of the manifest, both annotations apply.

dinhxuanvu

/lgtm

kevinrizza · 2022-01-05T15:45:15Z

/cherry-pick release-4.9

openshift-cherrypick-robot · 2022-01-05T15:45:15Z

@kevinrizza: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

awgreene · 2022-01-05T16:26:23Z

/retest

awgreene · 2022-01-05T16:26:30Z

/approve

openshift-ci · 2022-01-05T16:28:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, dinhxuanvu, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [awgreene,dinhxuanvu,kevinrizza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-01-05T17:44:57Z

/retest-required