Bug 2048563: feat added leader election conventions by eggfoobar · Pull Request #228 · openshift/operator-framework-olm

eggfoobar · 2021-12-13T22:13:16Z

This should take advantage of leader election changes for SNO clusters proposed in this library-go PR.

Changes:

updated leader election to follow convention and use different leader election for SNO topology

kevinrizza · 2021-12-14T14:20:41Z

@eggfoobar this PR seems reasonable to me, but I do want to call out that it only resolves the problem for the downstream only controller you updated, and none of the controllers that we're pulling in from the upstream operator-framework project in the staging directory.

eggfoobar · 2021-12-14T15:00:00Z

Thanks for the heads up @kevinrizza , I think I might have misunderstood then, from what I could see from the holderIdentity it seemed like just the downstream operator was doing leader election, the upstream project seemed to not have that setup just yet. Is this the right spot to look for that code ?

eggfoobar · 2021-12-17T21:54:18Z

/retest-required

ggiguash · 2021-12-22T09:38:48Z

/retest-required

ggiguash · 2021-12-23T11:33:30Z

/retest-required

ggiguash · 2021-12-23T20:28:05Z

/retest-required

qJkee · 2022-01-01T11:22:49Z

/retest-required

ggiguash · 2022-01-12T14:23:51Z

/retest-required

qJkee · 2022-01-13T13:11:06Z

/retest-required

ggiguash · 2022-01-15T10:19:14Z

/retest-required

ggiguash · 2022-01-18T11:11:24Z

/test e2e-upgrade

eggfoobar · 2022-01-21T15:32:18Z

/retest-required

kevinrizza · 2022-01-21T20:35:07Z

/retest
/approve

openshift-ci · 2022-01-21T20:35:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [kevinrizza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

eggfoobar · 2022-01-25T04:38:06Z

/retest-required

openshift-bot · 2022-02-06T02:25:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-06T06:01:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-06T06:37:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-06T08:13:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-06T10:49:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-06T11:01:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-06T14:27:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-06T14:53:38Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-06T16:44:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-06T17:08:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-06T19:20:40Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-06T19:32:39Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-06T22:44:41Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

dinhxuanvu · 2022-02-07T00:29:25Z

/hold

eggfoobar · 2022-02-22T06:06:59Z

/test e2e-upgrade

eggfoobar · 2022-02-22T13:17:52Z

Hey @dinhxuanvu seems the latest e2e-upgrade passed, should we remove the hold?

dinhxuanvu · 2022-02-22T14:16:13Z

/hold cancel

eggfoobar · 2022-02-22T16:42:43Z

/retest-required

openshift-bot · 2022-02-22T19:58:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-22T21:46:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-02-22T23:10:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

eggfoobar · 2022-02-23T03:48:52Z

/retest-required

openshift-ci · 2022-02-23T05:59:51Z

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci · 2022-02-23T06:00:55Z

@eggfoobar: All pull requests linked via external trackers have merged:

openshift/operator-framework-olm#228

Bugzilla bug 2048563 has been moved to the MODIFIED state.

Details

In response to this:

Bug 2048563: feat added leader election conventions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eggfoobar · 2022-02-28T13:59:20Z

/cherrypick release-4.10

openshift-cherrypick-robot · 2022-02-28T14:00:05Z

@eggfoobar: #228 failed to apply on top of branch "release-4.10":

Applying: feat: added leader election conventons
Applying: upkeep: ran make verify
Using index info to reconstruct a base tree...
M	go.mod
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 upkeep: ran make verify
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci Bot requested review from awgreene and kevinrizza December 13, 2021 22:13

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2021

eggfoobar force-pushed the leader_election_config branch from 7995341 to 7d8495d Compare December 16, 2021 05:43

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2021

eggfoobar force-pushed the leader_election_config branch from 7d8495d to 6947a74 Compare December 16, 2021 15:11

eggfoobar force-pushed the leader_election_config branch from 6947a74 to d5844fb Compare January 20, 2022 14:35

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2022

perdasilva reviewed Jan 22, 2022

View reviewed changes

Comment thread pkg/leaderelection/leaderelection.go Outdated

perdasilva reviewed Jan 22, 2022

View reviewed changes

Comment thread base.Dockerfile Outdated

eggfoobar force-pushed the leader_election_config branch 2 times, most recently from a45395d to 9037438 Compare January 24, 2022 20:05

eggfoobar changed the title ~~feat: added leader election conventons~~ Bug 2034484: feat added leader election conventons Jan 25, 2022

openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 25, 2022

dinhxuanvu mentioned this pull request Feb 7, 2022

Bug 1975543: Use CVO to delete manifests removed from OLM #245

Merged

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2022

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2022

openshift-merge-robot merged commit 6858269 into openshift:master Feb 23, 2022

Conversation

eggfoobar commented Dec 13, 2021

Uh oh!

kevinrizza commented Dec 14, 2021

Uh oh!

eggfoobar commented Dec 14, 2021

Uh oh!

eggfoobar commented Dec 17, 2021

Uh oh!

ggiguash commented Dec 22, 2021

Uh oh!

ggiguash commented Dec 23, 2021

Uh oh!

ggiguash commented Dec 23, 2021

Uh oh!

qJkee commented Jan 1, 2022

Uh oh!

ggiguash commented Jan 12, 2022

Uh oh!

qJkee commented Jan 13, 2022

Uh oh!

ggiguash commented Jan 15, 2022

Uh oh!

ggiguash commented Jan 18, 2022

Uh oh!

eggfoobar commented Jan 21, 2022

Uh oh!

kevinrizza commented Jan 21, 2022

Uh oh!

openshift-ci Bot commented Jan 21, 2022

Uh oh!

Uh oh!

Uh oh!

eggfoobar commented Jan 25, 2022

Uh oh!

openshift-bot commented Feb 6, 2022

Uh oh!

openshift-bot commented Feb 6, 2022

Uh oh!

openshift-bot commented Feb 6, 2022

Uh oh!

openshift-bot commented Feb 6, 2022

Uh oh!

openshift-bot commented Feb 6, 2022

Uh oh!

openshift-bot commented Feb 6, 2022

Uh oh!

openshift-bot commented Feb 6, 2022

Uh oh!

openshift-bot commented Feb 6, 2022

Uh oh!

openshift-bot commented Feb 6, 2022

Uh oh!

openshift-bot commented Feb 6, 2022

Uh oh!

openshift-bot commented Feb 6, 2022

Uh oh!

openshift-bot commented Feb 6, 2022

Uh oh!

openshift-bot commented Feb 6, 2022

Uh oh!

dinhxuanvu commented Feb 7, 2022

Uh oh!

eggfoobar commented Feb 22, 2022

Uh oh!

eggfoobar commented Feb 22, 2022

Uh oh!

dinhxuanvu commented Feb 22, 2022

Uh oh!

eggfoobar commented Feb 22, 2022

Uh oh!

openshift-bot commented Feb 22, 2022

Uh oh!

openshift-bot commented Feb 22, 2022

Uh oh!

openshift-bot commented Feb 22, 2022

Uh oh!

eggfoobar commented Feb 23, 2022

Uh oh!

openshift-ci Bot commented Feb 23, 2022