Bug 1985697: Update the package-server-manager leader election configuration by timflannagan · Pull Request #136 · openshift/operator-framework-olm

timflannagan · 2021-07-27T21:38:07Z

Update the package-server-manager controller and update the leader
election intervals. This is in order to comply with the need for OCP
components to be able to withstand 60s of API server disruption on
SNO-enabled clusters.

For more information, see the following resources:

Alternative implementations include disabling leader election entirely
for SNO-enabled clusters. This implementation is centered around
dynamically querying for the Infrastructure/cluster singleton resource,
checking the HA/non-HA expectations being exposed, and setting leader
election properly. This implementation would still need to be careful
about how to handle transient errors and provide an escape hatch (e.g.
prefer enablement of leader election through a CLI flag, vs. the dynamic
value) that users can pass to the PSM deployment for failed upgrades.

openshift-ci · 2021-07-27T21:38:13Z

@timflannagan: This pull request references Bugzilla bug 1985697, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

Bug 1985697: Update the package-server-manager leader election configuration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-07-27T21:38:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [timflannagan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Update the package-server-manager controller and update the leader election intervals. This is in order to comply with the need for OCP components to be able to withstand 60s of API server disruption on SNO-enabled clusters. For more information, see the following resources: - openshift/library-go#1104 (comment) - https://bugzilla.redhat.com/show_bug.cgi?id=1985697 Alternative implementations include disabling leader election entirely for SNO-enabled clusters. This implementation is centered around dynamically querying for the Infrastructure/cluster singleton resource, checking the HA/non-HA expectations being exposed, and setting leader election properly. This implementation would still need to be careful about how to handle transient errors and provide an escape hatch (e.g. prefer enablement of leader election through a CLI flag, vs. the dynamic value) that users can pass to the PSM deployment for failed upgrades.

cmd/package-server-manager/main.go

timflannagan · 2021-07-28T16:04:57Z

/retest

kevinrizza · 2021-08-04T17:39:42Z

/lgtm

openshift-bot · 2021-08-05T01:06:53Z

/retest-required