OPRUN-4588: use AlwaysAllow UnhealthyPodEvictionPolicy option in PDBs

[atiratree]

Allow eviction of unhealthy (not ready) pods even if there are no disruptions
allowed on a PodDisruptionBudget. This can help to drain/maintain a node and
recover without a manual intervention when multiple instances of nodes or pods
are misbehaving.

Summary by CodeRabbit

• Chores
  • Updated Pod Disruption Budget configuration to allow unhealthy pods to be evicted according to system disruption policies across package management components.

[openshift-ci-robot]

@atiratree: This pull request references OPRUN-4588 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Allow eviction of unhealthy (not ready) pods even if there are no disruptions
allowed on a PodDisruptionBudget. This can help to drain/maintain a node and
recover without a manual intervention when multiple instances of nodes or pods
are misbehaving. Use this with caution, as this option can disrupt perspective
pods that have not yet had a chance to become healthy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Three PodDisruptionBudget manifest files are updated to add an unhealthyPodEvictionPolicy: AlwaysAllow field to their specifications, enabling the eviction of unhealthy pods according to PDB rules while maintaining existing maxUnavailable and label selector configurations.

Changes

Cohort / File(s)	Summary
PodDisruptionBudget Configuration manifests/0000_50_olm_00-packageserver.pdb.yaml, microshift-manifests/0000_50_olm_00-packageserver.pdb.yaml, scripts/packageserver-pdb.yaml	Added unhealthyPodEvictionPolicy: AlwaysAllow field to packageserver-pdb PodDisruptionBudget spec across all three manifest files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly references the ticket (OPRUN-4588) and clearly describes the main change: enabling AlwaysAllow UnhealthyPodEvictionPolicy in PodDisruptionBudgets, which aligns with the changeset modifications across three manifest files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only YAML manifest files defining Kubernetes PodDisruptionBudget resources, not Ginkgo test files.
Test Structure And Quality	✅ Passed	PR modifies only YAML manifest files with no test code changes; Ginkgo test quality check is not applicable.
Microshift Test Compatibility	✅ Passed	PR only modifies YAML PodDisruptionBudget manifest files and does not add new Ginkgo e2e tests.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only modifies Kubernetes YAML manifest files for PodDisruptionBudget resources and does not introduce any new Ginkgo e2e tests.
Topology-Aware Scheduling Compatibility	✅ Passed	PodDisruptionBudget uses maxUnavailable: 1, which is topology-appropriate for two-node clusters and compatible with 2-replica deployments. The unhealthyPodEvictionPolicy: AlwaysAllow setting enhances cluster maintenance across all topologies.
Ote Binary Stdout Contract	✅ Passed	The OTE Binary Stdout Contract check is not applicable. The PR modifies only Kubernetes YAML manifest files, which are static configuration files, not executable code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR only modifies YAML manifest files defining Kubernetes PodDisruptionBudget resources. The custom check assesses IPv4 assumptions and external connectivity in Ginkgo e2e tests. Since no Ginkgo e2e tests were added, the check is not applicable.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atiratree
Once this PR has been reviewed and has the lgtm label, please assign grokspawn for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[atiratree]

/retest

[grokspawn]

/retest-required

[grokspawn]

Hi @atiratree. Thanks for the PR. I checked https://redhat.atlassian.net/browse/OPRUN-4588 but I did not see any analogue for OLMv1, only the OLMv0 issue.

For olmv1, the repo is https://github.com/operator-framework/operator-controller and it looks like it would need updates for the files:

• manifests/standard.yaml
• manifests/experimental.yaml
• manifests/standard-e2e.yaml
• manifests/experimental-e2e.yaml
• helm/olmv1/templates/poddisruptionbudget-olmv1-system-catalogd.yml
• helm/olmv1/templates/poddisruptionbudget-olmv1-system-operator-controller.yml
  (probably just the templates, and then re-generate the manifests)

[openshift-ci]

@atiratree: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-upgrade-ovn-single-node	e99debc	link	false	/test e2e-aws-upgrade-ovn-single-node
ci/prow/e2e-upgrade	e99debc	link	true	/test e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[atiratree]

Thanks @grokspawn, I will look into that and open a PR against OLMv1 as well.

[atiratree]

/retest

[atiratree]

Please see operator-framework/operator-controller#2688 for OLMv1