Skip to content

OCPBUGS-77712: Update NetworkPolicy egress to support HyperShift custom API ports#1246

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:release-4.21from
rashmigottipati:OCPBUGS-77712-backport-np-4.21
Mar 9, 2026
Merged

OCPBUGS-77712: Update NetworkPolicy egress to support HyperShift custom API ports#1246
openshift-merge-bot[bot] merged 2 commits intoopenshift:release-4.21from
rashmigottipati:OCPBUGS-77712-backport-np-4.21

Conversation

@rashmigottipati
Copy link
Copy Markdown
Member

@rashmigottipati rashmigottipati commented Mar 4, 2026

Backport of NetworkPolicy changes to support HyperShift custom API ports.

This PR is a manual cherry-pick of the following commits from main:

  • 49626b5: OCPBUGS-76971: Update NetworkPolicy egress to support HyperShift custom API ports
  • a1e313a: update the network policy port per new change
  • 16791e3: Update downstream NetworkPolicies for HyperShift
  • e537de8: Remove aliases and selectors from NetworkPolicy tests

Related: OCPBUGS-76971

@rashmigottipati
OCPBUGS-77712: Update NetworkPolicy egress to support HyperShift cust…
7a698ea 
…om API ports

Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 4, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 4, 2026

@rashmigottipati: This pull request references Jira Issue OCPBUGS-77712, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-76971 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-76971 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
  • bug has dependents

Requesting review from QA contact:
/cc @kuiwang02

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Backport of NetworkPolicy changes to support HyperShift custom API ports.

This PR is a manual cherry-pick of the following commits from main:

  • 49626b5: OCPBUGS-76971: Update NetworkPolicy egress to support HyperShift custom API ports
  • a1e313a: update the network policy port per new change
  • 16791e3: Update downstream NetworkPolicies for HyperShift
  • e537de8: Remove aliases and selectors from NetworkPolicy tests

Related: OCPBUGS-76971

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rashmigottipati
Copy link
Copy Markdown
Member Author

rashmigottipati commented Mar 4, 2026 •
edited
Loading

cc @tmshort @kuiwang02

kuiwang02
kuiwang02 reviewed Mar 4, 2026
View reviewed changes
Comment thread manifests/0000_90_olm_00-service-monitor.yaml Outdated
- get
- list
- watch
- apiGroups:
Copy link
Copy Markdown
Contributor

@kuiwang02 kuiwang02 Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rashmigottipati I am not sure if it is needed for np.

Comment thread microshift-manifests/0000_90_olm_00-service-monitor.yaml Outdated
- get
- list
- watch
- apiGroups:
Copy link
Copy Markdown
Contributor

@kuiwang02 kuiwang02 Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rashmigottipati same comment with above.

Copy link
Copy Markdown
Contributor

@kuiwang02 kuiwang02 Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_operator-framework-olm/1246/pull-ci-openshift-operator-framework-olm-release-4.21-verify/2029029526679326720 is failing as well.

@kuiwang02
Copy link
Copy Markdown
Contributor

kuiwang02 commented Mar 4, 2026

I will create cluster to try it.

@rashmigottipati
Update generated manifests for release-4.21
435e2ef 
Signed-off-by: Rashmi Gottipati <rgottipa@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 4, 2026

@rashmigottipati: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@perdasilva
Copy link
Copy Markdown
Contributor

perdasilva commented Mar 4, 2026

/lgtm

as a cherry-pick it seems fine to me. I'll let @kuiwang02 approve if he's satisfied with how it works on the cluster =D

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2026
@tmshort
Copy link
Copy Markdown
Contributor

tmshort commented Mar 4, 2026

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2026
@jianzhangbjz
Copy link
Copy Markdown
Contributor

jianzhangbjz commented Mar 6, 2026

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 6, 2026
@kuiwang02
Copy link
Copy Markdown
Contributor

kuiwang02 commented Mar 8, 2026

/verified by @kuiwang02

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 8, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 8, 2026

@kuiwang02: This PR has been marked as verified by @kuiwang02.

Details

In response to this:

/verified by @kuiwang02

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit 58e4b42 into openshift:release-4.21 Mar 9, 2026
15 checks passed
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 9, 2026

@rashmigottipati: Jira Issue Verification Checks: Jira Issue OCPBUGS-77712
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-77712 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Backport of NetworkPolicy changes to support HyperShift custom API ports.

This PR is a manual cherry-pick of the following commits from main:

  • 49626b5: OCPBUGS-76971: Update NetworkPolicy egress to support HyperShift custom API ports
  • a1e313a: update the network policy port per new change
  • 16791e3: Update downstream NetworkPolicies for HyperShift
  • e537de8: Remove aliases and selectors from NetworkPolicy tests

Related: OCPBUGS-76971

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rashmigottipati rashmigottipati mentioned this pull request Mar 9, 2026
Merged
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Mar 10, 2026

Fix included in accepted release 4.21.0-0.nightly-2026-03-09-195610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@tmshort tmshort Awaiting requested review from tmshort

1 more reviewer

@kuiwang02 kuiwang02 kuiwang02 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bandrade bandrade

@perdasilva perdasilva

@jianzhangbjz jianzhangbjz

@kuiwang02 kuiwang02

@Xia-Zhao-rh Xia-Zhao-rh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@rashmigottipati @openshift-ci-robot @kuiwang02 @perdasilva @tmshort @jianzhangbjz @openshift-merge-robot @bandrade @Xia-Zhao-rh