Skip to content

NO-ISSUE: Make downstream csv namespace labeler plugin e2e more resilient to race conditions#1074

Closed
perdasilva wants to merge 1 commit intoopenshift:mainfrom
perdasilva:csv-namespace-labeler-fix
Closed

NO-ISSUE: Make downstream csv namespace labeler plugin e2e more resilient to race conditions#1074
perdasilva wants to merge 1 commit intoopenshift:mainfrom
perdasilva:csv-namespace-labeler-fix

Conversation

@perdasilva
Copy link
Copy Markdown
Contributor

An e2e test for the downstream csv namespace labeler plugin can suffer from race conditions if the namespace resource changes between the get and update operations. This PR also deprecates the determined client's update method, since retrying update operations on failure doesn't help with conflict errors....

…ore resilient to race conditions

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva perdasilva changed the title UPSTREAM: <carry>: make downstream csv namespace labeler plugin e2e more resilient to race conditions NO-ISSUE: Make downstream csv namespace labeler plugin e2e more resilient to race conditions Sep 6, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 6, 2025
@openshift-ci-robot
Copy link
Copy Markdown

@perdasilva: This pull request explicitly references no jira issue.

Details

In response to this:

An e2e test for the downstream csv namespace labeler plugin can suffer from race conditions if the namespace resource changes between the get and update operations. This PR also deprecates the determined client's update method, since retrying update operations on failure doesn't help with conflict errors....

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2025
@perdasilva
Copy link
Copy Markdown
Contributor Author

/retest

@perdasilva
Copy link
Copy Markdown
Contributor Author

/retest

@perdasilva perdasilva closed this Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants