-
Notifications
You must be signed in to change notification settings - Fork 78
OCPBUGS-60525: Add NetworkPolicy as a supported kind #1047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-60525: Add NetworkPolicy as a supported kind #1047
Conversation
Signed-off-by: Anik Bhattacharjee <[email protected]> Upstream-repository: operator-registry Upstream-commit: 919aefdce3f4d6b77c3872df249815d20749db94
|
@anik120: This pull request references Jira Issue OCPBUGS-60525, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@anik120: This pull request references Jira Issue OCPBUGS-60525, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@anik120: This pull request references Jira Issue OCPBUGS-60525, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold I have to update the PR to include a "allow-all" NP for the |
9abfb83 to
1aa6bb5
Compare
|
/hold cancel note to reviewers: I add to pull in the allow-all NP manually, since this commit which has a lot of NP stuff included the openshift-operators namespace NP too. |
|
If anyone has a better idea for what should go in the commit message I'm happy to switch it to that. |
|
@anik120 |
Signed-off-by: Rashmi Gottipati <[email protected]> Upstream-repository: operator-lifecycle-manager Upstream-commit: d7aaeb11ab80f862fc9c70dfb7865158bb67e28c
|
@kuiwang02 looks like I'd missed a commit earlier. It should pass now. PTAL, thank you! |
|
pre-verify with pass. please refer to the jira ticket's comment. thanks |
|
/retest |
|
/hold cancel /jira refresh |
|
@anik120: This pull request references Jira Issue OCPBUGS-60525, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@anik120: This pull request references Jira Issue OCPBUGS-60525, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-gcp-olm |
|
Looks like the verify is complaining because the manifest verification detects changes. Let me know when that's resolved, and I'll take another look. |
@grokspawn regenerated and pushed a new commit, it's passing now, PTAL |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anik120, grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@anik120: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5c83a8a
into
openshift:release-4.19
|
@anik120: Jira Issue OCPBUGS-60525: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-60525 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-operator-framework-tools |
|
[ART PR BUILD NOTIFIER] Distgit: operator-registry |
|
[ART PR BUILD NOTIFIER] Distgit: operator-lifecycle-manager |
|
/cherry-pick release-4.18 |
|
@anik120: new pull request created: #1048 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Upstream-repository: operator-registry
Upstream-commit: 919aefdce3f4d6b77c3872df249815d20749db94