Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove shebang + main function from dynamic client #252

Merged
merged 2 commits into from
Jan 3, 2019
Merged

Remove shebang + main function from dynamic client #252

merged 2 commits into from
Jan 3, 2019

Conversation

fabianvf
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 19, 2018
djzager
djzager approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally I thought it would be nice to move this into a helper. After thinking about it though I don't think that is necessary.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 19, 2018
@fabianvf
Copy link
Member Author

Yeah I might add it back in as a development script or something, but it certainly doesn't need to be in a release.

@fabianvf fabianvf merged commit d59353f into openshift:master Jan 3, 2019
@fabianvf
Copy link
Member Author

fabianvf commented Jan 3, 2019

/cherrypick release-0.8

@openshift-cherrypick-robot
Copy link

@fabianvf: #252 failed to apply on top of branch "release-0.8":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	openshift/dynamic/client.py
Falling back to patching base and 3-way merge...
Auto-merging openshift/dynamic/client.py
CONFLICT (content): Merge conflict in openshift/dynamic/client.py
Patch failed at 0001 Remove shebang + main function from dynamic client

In response to this:

/cherrypick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

willthames pushed a commit to willthames/openshift-restclient-python that referenced this pull request Feb 3, 2019
@fabianvf @willthames
Remove shebang + main function from dynamic client (openshift#252)
db99988 
* Remove shebang + main function from dynamic client

* remove unused imports
willthames pushed a commit to willthames/openshift-restclient-python that referenced this pull request Nov 22, 2019
@fabianvf @willthames
Remove shebang + main function from dynamic client (openshift#252)
468f67f 
* Remove shebang + main function from dynamic client

* remove unused imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djzager djzager djzager approved these changes

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabianvf @openshift-cherrypick-robot @djzager @openshift-ci-robot