Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When searching for resources, prefer non-List matches #231

Merged
merged 2 commits into from
Nov 6, 2018

Conversation

fabianvf
Copy link
Member

@fabianvf fabianvf commented Nov 6, 2018

Signed-off-by: Fabian von Feilitzsch [email protected]

Fixes #229

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 6, 2018
@fabianvf
Copy link
Member Author

fabianvf commented Nov 6, 2018

/cherrypick release-0.8

@openshift-cherrypick-robot

@fabianvf: once the present PR merges, I will cherry-pick it on top of release-0.8 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 6, 2018
@fabianvf
Copy link
Member Author

fabianvf commented Nov 6, 2018

ping @djzager

@fabianvf fabianvf requested a review from djzager November 6, 2018 16:22
@djzager
Copy link
Member

djzager commented Nov 6, 2018

/lgtm

@openshift-cherrypick-robot

@fabianvf: new pull request created: #232

In response to this:

/cherrypick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

willthames pushed a commit to willthames/openshift-restclient-python that referenced this pull request Dec 13, 2018
* Fixes openshift#229: When searching for resources, prefer non-List matches

Signed-off-by: Fabian von Feilitzsch <[email protected]>

* add unit test for resource searching behavior

Signed-off-by: Fabian von Feilitzsch <[email protected]>
willthames pushed a commit to willthames/openshift-restclient-python that referenced this pull request Nov 22, 2019
* Fixes openshift#229: When searching for resources, prefer non-List matches

Signed-off-by: Fabian von Feilitzsch <[email protected]>

* add unit test for resource searching behavior

Signed-off-by: Fabian von Feilitzsch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants