Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceContainer does not contain delete method #227

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

morsik
Copy link
Contributor

@morsik morsik commented Oct 31, 2018

I was falling into:

Traceback (most recent call last):
  File "/home/morsik/Projects/venv/lib/python3.6/site-packages/apscheduler/executors/base.py", line 125, in run_job
    retval = job.func(*job.args, **job.kwargs)
  File "/home/morsik/Projects/venv/lib/python3.6/site-packages/nameguard-1.0-py3.6.egg/nameguard/nameguard.py", line 196, in job_delete_project
    v1_projects = ctx.client.resources.delete(
AttributeError: 'ResourceContainer' object has no attribute 'delete'

It looks like first example contains .get() which works, but this one I changed contains .delete() which does not exists in code there. Looks like using .get() works.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2018
@openshift-ci-robot
Copy link

Hi @morsik. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 31, 2018
@djzager
Copy link
Member

djzager commented Oct 31, 2018

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 31, 2018
@djzager
Copy link
Member

djzager commented Oct 31, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2018
@fabianvf
Copy link
Member

Build failure obviously unrelated, issue with flake8 package update. Thanks for catching this @morsik!

@fabianvf fabianvf merged commit 1b80c5c into openshift:master Oct 31, 2018
fabianvf pushed a commit to fabianvf/openshift-restclient-python that referenced this pull request Nov 5, 2018
willthames pushed a commit to willthames/openshift-restclient-python that referenced this pull request Nov 22, 2018
willthames pushed a commit to willthames/openshift-restclient-python that referenced this pull request Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants