Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First stab at watch implementation #221

Merged
merged 5 commits into from
Nov 2, 2018
Merged

First stab at watch implementation #221

merged 5 commits into from
Nov 2, 2018

Conversation

fabianvf
Copy link
Member

@fabianvf fabianvf commented Oct 4, 2018

Closes #203

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 4, 2018
@fabianvf
Copy link
Member Author

fabianvf commented Oct 5, 2018

@willthames, could be useful for the wait work we were talking about Ansible-side

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 31, 2018
@fabianvf
Copy link
Member Author

@dbazhal The second commit should fix the issue you were seeing with resource_version=0

@djzager
Copy link
Member

djzager commented Oct 31, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Oct 31, 2018
@djzager
Copy link
Member

djzager commented Oct 31, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2018
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2018
@djzager
Copy link
Member

djzager commented Oct 31, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2018
@fabianvf fabianvf merged commit 2bf10ca into openshift:master Nov 2, 2018
fabianvf added a commit to fabianvf/openshift-restclient-python that referenced this pull request Nov 5, 2018
@fabianvf
Add watch to dynamic client (openshift#221)
86b3252 
* First stab at watch implementation

* add docs

* remove extraneous newline

* Fixes openshift#203 fix query parameter checking to prevent filtering out valid falsey values

* Add docstring for watch

(cherry picked from commit 2bf10ca)
willthames pushed a commit to willthames/openshift-restclient-python that referenced this pull request Dec 13, 2018
@fabianvf @willthames
Add watch to dynamic client (openshift#221)
6772919 
* First stab at watch implementation

* add docs

* remove extraneous newline

* Fixes openshift#203 fix query parameter checking to prevent filtering out valid falsey values

* Add docstring for watch
willthames pushed a commit to willthames/openshift-restclient-python that referenced this pull request Nov 22, 2019
@fabianvf @willthames
Add watch to dynamic client (openshift#221)
0904c02 
* First stab at watch implementation

* add docs

* remove extraneous newline

* Fixes openshift#203 fix query parameter checking to prevent filtering out valid falsey values

* Add docstring for watch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@djzager djzager

Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabianvf @djzager @openshift-ci-robot