Skip to content

proof: Add openshift-core toolset with node and must-gather tools#69

Closed
swghosh wants to merge 7 commits intoopenshift:mainfrom
swghosh:node+plan-mg
Closed

proof: Add openshift-core toolset with node and must-gather tools#69
swghosh wants to merge 7 commits intoopenshift:mainfrom
swghosh:node+plan-mg

Conversation

@swghosh
Copy link
Member

@swghosh swghosh commented Nov 5, 2025

combination of #38 + #51

TODO:

  • adapt OpenshiftClientAdapter in pkg/ocp/nodes to decouple out and export ResourcesGet, CanIUse
    • accordingly update/refactor plan_mustgather tool

@openshift-ci openshift-ci bot requested review from Cali0707 and matzew November 5, 2025 18:16
harche and others added 6 commits February 3, 2026 15:42
@swghosh swghosh changed the title implement plan_mustgather into the ocp toolset Add openshift-core toolset (includes node, must-gather) Feb 3, 2026
@swghosh swghosh changed the title Add openshift-core toolset (includes node, must-gather) Add openshift-core toolset with node and must-gather tools Feb 3, 2026
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swghosh
Once this PR has been reviewed and has the lgtm label, please assign kaustubh-pande for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2026

@swghosh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test 30efff5 link true /test test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

// IMPORTANT: this file is used to override default config values in downstream builds.
// This is intentionally left blank.
// OpenShift-specific defaults: add openshift-core toolset
Toolsets: []string{"core", "config", "helm", "openshift-core"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we directly want to ship those, on the downstream repo?

I'd assume that we keep them disabled for a bit - so that explicit user enablement is required.

To ensure the tools are mature it would be nice to also have evals as part of a future enablement

@swghosh
Copy link
Member Author

swghosh commented Feb 11, 2026

This was originally developed as a proof of concept to show how different OCP components could put their tools into a new OpenShift toolset in an extensible manner, with "mustgather" and "node" being examples components.

/close
in favour of #51 (we want to land it first)

Thanks @matzew for the direction!

@openshift-ci openshift-ci bot closed this Feb 11, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2026

@swghosh: Closed this PR.

Details

In response to this:

This was originally developed as a proof of concept to show how different OCP components could put their tools into the "openshift" toolset in an extensible manner, with mustgather and node being examples components.

/close
in favour of #51 (we want to land it first)

Thanks @matzew for the direction!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@swghosh swghosh changed the title Add openshift-core toolset with node and must-gather tools proof: Add openshift-core toolset with node and must-gather tools Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants