proof: Add openshift-core toolset with node and must-gather tools#69
proof: Add openshift-core toolset with node and must-gather tools#69swghosh wants to merge 7 commits intoopenshift:mainfrom
Conversation
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: swghosh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@swghosh: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| // IMPORTANT: this file is used to override default config values in downstream builds. | ||
| // This is intentionally left blank. | ||
| // OpenShift-specific defaults: add openshift-core toolset | ||
| Toolsets: []string{"core", "config", "helm", "openshift-core"}, |
There was a problem hiding this comment.
Do we directly want to ship those, on the downstream repo?
I'd assume that we keep them disabled for a bit - so that explicit user enablement is required.
To ensure the tools are mature it would be nice to also have evals as part of a future enablement
|
This was originally developed as a proof of concept to show how different OCP components could put their tools into a new OpenShift toolset in an extensible manner, with "mustgather" and "node" being examples components. /close Thanks @matzew for the direction! |
|
@swghosh: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
combination of #38 + #51
TODO:
OpenshiftClientAdapterinpkg/ocp/nodesto decouple out and export ResourcesGet, CanIUse