-
Notifications
You must be signed in to change notification settings - Fork 1.9k
PT1: Port the Log collection and forwarding chapter to 6.x #94409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PT1: Port the Log collection and forwarding chapter to 6.x #94409
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test all |
|
🤖 Fri Sep 19 12:11:55 - Prow CI generated the docs preview: https://94409--ocpdocs-pr.netlify.app/ |
73b5c15 to
03be7c1
Compare
theashiot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jcantrill for the review! I've made some of suggested changes and added comments where I couldn't, and also added a question. Mind having another look?
best,
ashwin
fb7a66e to
067317f
Compare
cahartma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change and possibly some verbiage updates/additions.
067317f to
29ee1d6
Compare
|
Thanks, @cahartma for the review! I've made all the changes. Mind having another look? best, |
cahartma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
29ee1d6 to
c96af39
Compare
|
New changes are detected. LGTM label has been removed. |
|
LGTM. |
gabriel-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - very minor comments, but xref does need to be removed from module
c96af39 to
1ff2ca9
Compare
|
Thanks, @gabriel-rh for the review! I've made all the changes. best, |
|
/retest |
1ff2ca9 to
5f52bf4
Compare
5f52bf4 to
83cd89b
Compare
|
@theashiot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
fbb90d3
into
openshift:standalone-logging-docs-main
|
/cherrypick standalone-logging-docs-6.0 |
|
@briandooley: #94409 failed to apply on top of branch "standalone-logging-docs-6.0": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick standalone-logging-docs-6.1 |
|
/cherrypick standalone-logging-docs-6.2 |
|
/cherrypick standalone-logging-docs-6.3 |
|
/cherrypick standalone-logging-docs-6.4 |
|
@briandooley: #94409 failed to apply on top of branch "standalone-logging-docs-6.1": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@briandooley: new pull request created: #99394 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@briandooley: new pull request created: #99395 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@briandooley: #94409 failed to apply on top of branch "standalone-logging-docs-6.4": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
Issue: https://issues.redhat.com/browse/OBSDOCS-2305
Link to docs preview:
QE review:
Additional information: