Skip to content

Conversation

@gwynnemonahan
Copy link
Contributor

@gwynnemonahan gwynnemonahan commented May 28, 2025

https://issues.redhat.com/browse/OSDOCS-14786 [NetObserv] Add section for IPsec

Version(s):
Merge to only the no-1.9 branch - no cherrypicks are required.
I will open one PR against main to incorporate all of the NetObserv content just before its GA.

Issue:
https://issues.redhat.com/browse/OSDOCS-14786

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
API reference updates are being handled by #94756

First time doing NETOBSERV release, and did not realize API/CLI changes were automatically generated, and those updates to prod docs are generally handed separately and not in individual PRs where CLI/API changes may occur.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 28, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 28, 2025

🤖 Tue Jun 24 14:30:46 - Prow CI generated the docs preview:
https://93858--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 28, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2025
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 13, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2025
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 13, 2025
@memodi
Copy link

memodi commented Jun 16, 2025

/cc @memodi

@openshift-ci openshift-ci bot requested a review from memodi June 16, 2025 14:14
Copy link

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're missing:

  1. how users would configure IPSec in flowcollector. Should we mention alongside other features that can be enabled in .spec.agent.ebpf.features
  2. what additional metrics or dashboard panels they would see when IPSec is enabled in flowcollector?

@memodi
Copy link

memodi commented Jun 16, 2025

we're missing:

  1. how users would configure IPSec in flowcollector. Should we mention alongside other features that can be enabled in .spec.agent.ebpf.features
  2. what additional metrics or dashboard panels they would see when IPSec is enabled in flowcollector?

for #1 we should add a similar section as exists for other features like DNSTracking/PacketDrop etc. starting section 7.2.4 https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html-single/network_observability/index#network-observability-packet-drops_nw-observe-network-traffic

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 16, 2025
@jotak
Copy link

jotak commented Jun 20, 2025

/lgtm
thanks @gwynnemonahan !

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2025
Copy link

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label qe-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 20, 2025
…rt.adoc

OSDOCS-14366 Additional context concept about the multi-flow filtering capability

[NETOBSERV-2053] Flowlogs Flp filtering

OSDOCS-13901 NetObserv 1.9 CLI documentation updates

OSDOCS-14850 Update callout <2>

OSDOCS-14861 [NETOBSERV] Update netobserv-reader to netobserv-loki-reader

OSDOCS-14822 UDN NetObserv Content

OSDOCS-14786 [NetObserv] Add section for IPsec

Configuration added (Squash)

Squash

File name change since now proc instead of con (Squash)

New dashboard generated added to Verification (Squash)
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2025

New changes are detected. LGTM label has been removed.

This reverts commit fe38681ff8a3e5f31d4f9235a829d35c4d0bfa31.
…ck-convert.adoc"

This reverts commit 5e4967bc97ebfa4efc96a53c356504a288128855.
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 24, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2025

@gwynnemonahan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gwynnemonahan
Copy link
Contributor Author

Handled by PR 95159. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants