-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OSDOCS-14786 [NetObserv] Add section for IPsec #93858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Tue Jun 24 14:30:46 - Prow CI generated the docs preview: |
observability/network_observability/observing-network-traffic.adoc
Outdated
Show resolved
Hide resolved
20f05ff to
9c7d78e
Compare
1a8a4fa to
4dc7d57
Compare
|
/cc @memodi |
memodi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're missing:
- how users would configure IPSec in flowcollector. Should we mention alongside other features that can be enabled in
.spec.agent.ebpf.features - what additional metrics or dashboard panels they would see when IPSec is enabled in flowcollector?
for #1 we should add a similar section as exists for other features like DNSTracking/PacketDrop etc. starting section 7.2.4 https://docs.redhat.com/en/documentation/openshift_container_platform/4.18/html-single/network_observability/index#network-observability-packet-drops_nw-observe-network-traffic |
|
/lgtm |
memodi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label qe-approved
…rt.adoc OSDOCS-14366 Additional context concept about the multi-flow filtering capability [NETOBSERV-2053] Flowlogs Flp filtering OSDOCS-13901 NetObserv 1.9 CLI documentation updates OSDOCS-14850 Update callout <2> OSDOCS-14861 [NETOBSERV] Update netobserv-reader to netobserv-loki-reader OSDOCS-14822 UDN NetObserv Content OSDOCS-14786 [NetObserv] Add section for IPsec Configuration added (Squash) Squash File name change since now proc instead of con (Squash) New dashboard generated added to Verification (Squash)
656d6fb to
d0507da
Compare
|
New changes are detected. LGTM label has been removed. |
This reverts commit fe38681ff8a3e5f31d4f9235a829d35c4d0bfa31.
…ck-convert.adoc" This reverts commit 5e4967bc97ebfa4efc96a53c356504a288128855.
|
@gwynnemonahan: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Handled by PR 95159. Closing this one. |
https://issues.redhat.com/browse/OSDOCS-14786 [NetObserv] Add section for IPsec
Version(s):
Merge to only the
no-1.9branch - no cherrypicks are required.I will open one PR against main to incorporate all of the NetObserv content just before its GA.
Issue:
https://issues.redhat.com/browse/OSDOCS-14786
Link to docs preview:
QE review:
Additional information:
API reference updates are being handled by #94756
First time doing NETOBSERV release, and did not realize API/CLI changes were automatically generated, and those updates to prod docs are generally handed separately and not in individual PRs where CLI/API changes may occur.