-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OSDOCS-13901 NetObserv 1.9 CLI documentation updates #93795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Thu Jun 05 16:00:20 - Prow CI generated the docs preview: |
jotak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jpinsonneau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @gwynnemonahan 🥳
b07936a to
5018be5
Compare
|
/label peer-review-needed |
|
@gwynnemonahan Just a minor nit. Otherwise LGTM. |
5c740c6 to
450ca7d
Compare
|
@gwynnemonahan: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label merge-review-needed |
|
The original text isn't capitalized but aren't table cell contents supposed to be capitalized? Maybe this is an exception. I'll go ahead and merge but thought I would note it. |
https://issues.redhat.com/browse/OSDOCS-13901 NetObserv 1.9 CLI documentation updates
Version(s):
Merge to only the
no-1.9branch - no cherrypicks are required.I will open one PR against main to incorporate all of the NetObserv content just before its GA.
Cherry-pick to OCP 4.12, 4.14, 4.16+
Issue:
https://issues.redhat.com/browse/OSDOCS-13901
Link to docs preview:
QE review:
Additional information: