-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OCPBUGS-52653 updated the tar code in step 3 and also added sentence in step 3 about unique cluster ID #91615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a19398f to
76268f8
Compare
| . Create a compressed file from the `must-gather` directory that was just created in your working directory. For example, on a computer that uses a Linux | ||
| operating system, run the following command: | ||
| . Create a compressed file from the `must-gather` directory that was just created in your working directory. Make sure you provide the date and cluster ID for a unique must-gather. For moe information on how to fiind the cluster ID, see the Red Hat Knowledge base solution link:https://access.redhat.com/solutions/5280291[How to find the cluster-id or name on Opeshift cluster]. For example, on a computer that uses a Linux operating system, run the following command: | ||
| + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo fiind the cluster ID , please update , thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhouying7780 Can you please review the docs again under "Links to doc preview" above. Thanks.
modules/support-gather-data.adoc
Outdated
| $ tar cvaf must-gather.tar.gz must-gather.local.5421342344627712289/ <1> | ||
| $ tar cvaf must-gather-`date +"%m-%d-%Y-%H-%M-%S"`-$CLUSTERID.tar.gz must-gather.local.426787175854303238 <1> | ||
| ---- | ||
| <1> Make sure to replace `must-gather-local.5421342344627712289/` with the actual directory name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here should be the same as the example : must-gather.local.426787175854303238
76268f8 to
2357de0
Compare
2357de0 to
120edde
Compare
|
@wgabor0427 The typo and for |
33376bd to
421df5a
Compare
99e4dd0 to
aa4f0ee
Compare
|
/lgtm |
|
/label peer-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments; otherwise LGTM
| By default, the `must-gather` tool collects the OVN `nbdb` and `sbdb` databases from all of the nodes in the cluster. Adding the `-- gather_network_logs` option to include additional logs that contain OVN-Kubernetes transactions for OVN `nbdb` database. | ||
| ==== | ||
| . Create a compressed file from the `must-gather` directory that was just created in your working directory. For example, on a computer that uses a Linux operating system, run the following command: | ||
| . Create a compressed file from the `must-gather` directory that was just created in your working directory. Make sure you provide the date and cluster ID for a unique must-gather. For more information on how to find the cluster ID, see the Red Hat Knowledge base solution link:https://access.redhat.com/solutions/5280291[How to find the cluster-id or name on OpenShift cluster]. For example, on a computer that uses a Linux operating system, run the following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Create a compressed file from the `must-gather` directory that was just created in your working directory. Make sure you provide the date and cluster ID for a unique must-gather. For more information on how to find the cluster ID, see the Red Hat Knowledge base solution link:https://access.redhat.com/solutions/5280291[How to find the cluster-id or name on OpenShift cluster]. For example, on a computer that uses a Linux operating system, run the following command: | |
| . Create a compressed file from the `must-gather` directory that was just created in your working directory. Make sure you provide the date and cluster ID for a unique must-gather data. For more information about how to find the cluster ID, see link:https://access.redhat.com/solutions/5280291[How to find the cluster-id or name on OpenShift cluster]. For example, on a computer that uses a Linux operating system, run the following command: |
- "....a unique must-gather": Assuming this is poiniting to a unique must-gather data. If not, please replace with the suitable name/term.
- "...Knowledge base solution" can be omitted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Replaced "for a unique must-gather" with "for the unique must-gather data."
- Deleted "Knowledge base solution"
| [source,terminal] | ||
| ---- | ||
| $ tar cvaf must-gather.tar.gz must-gather.local.472290403699006248 <1> | ||
| $ tar cvaf must-gather-`date +"%m-%d-%Y-%H-%M-%S"`-$CLUSTERID.tar.gz must-gather.local.426787175854303238 <1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| $ tar cvaf must-gather-`date +"%m-%d-%Y-%H-%M-%S"`-$CLUSTERID.tar.gz must-gather.local.426787175854303238 <1> | |
| $ tar cvaf must-gather-`date +"%m-%d-%Y-%H-%M-%S"`-<cluster_id>.tar.gz <must_gather_local_dir> <1> |
- I'd suggest to use a user-replaced variable for cluster id. I believe
$is not needed for <cluster_id>. You might want to confirm with SME/QE. - because
must-gather.local.426787175854303238is replaceable, suggestion to use a placeholder --<must_gather_local_dir>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Added the user-replaced variable <cluster_id>
- Added the placeholder <must_gather_local_dir>
| $ tar cvaf must-gather.tar.gz must-gather.local.472290403699006248 <1> | ||
| $ tar cvaf must-gather-`date +"%m-%d-%Y-%H-%M-%S"`-$CLUSTERID.tar.gz must-gather.local.426787175854303238 <1> | ||
| ---- | ||
| <1> Replace `must-gather-local.472290403699006248` with the actual directory name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <1> Replace `must-gather-local.472290403699006248` with the actual directory name. | |
| <1> Replace `<must_gather_local_dir>` with the actual directory name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
| ifndef::openshift-origin[] | ||
| . Create a compressed file from the `must-gather` directory that was just created in your working directory. For example, on a computer that uses a Linux | ||
| . Create a compressed file from the `must-gather` directory that was just created in your working directory. Make sure you provide the date and cluster ID for a unique must-gather. For more information on how to find the cluster ID, see the Red Hat Knowledge base solution link:https://access.redhat.com/solutions/5280291[How to find the cluster-id or name on OpenShift cluster]. For example, on a computer that uses a Linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as earlier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made same edits in this file
| [source,terminal] | ||
| ---- | ||
| $ tar cvaf must-gather.tar.gz must-gather.local.5421342344627712289/ <1> | ||
| $ tar cvaf must-gather-`date +"%m-%d-%Y-%H-%M-%S"`-$CLUSTERID.tar.gz must-gather.local.426787175854303238 <1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as earlier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made same edits in this file
| $ tar cvaf must-gather-`date +"%m-%d-%Y-%H-%M-%S"`-$CLUSTERID.tar.gz must-gather.local.426787175854303238 <1> | ||
| ---- | ||
| <1> Make sure to replace `must-gather-local.5421342344627712289/` with the | ||
| <1> Make sure to replace `must-gather.local.426787175854303238` with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <1> Make sure to replace `must-gather.local.426787175854303238` with the | |
| <1> Make sure to replace `<must_gather_local_dir>` with the actual directory name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made changes
| ---- | ||
| <1> Make sure to replace `must-gather-local.5421342344627712289/` with the | ||
| <1> Make sure to replace `must-gather.local.426787175854303238` with the | ||
| actual directory name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| actual directory name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the same changes to this file as above
modules/support-gather-data.adoc
Outdated
|
|
||
| . Create a compressed file from the `must-gather` directory that was just created in your working directory. For example, on a computer that uses a Linux | ||
| operating system, run the following command: | ||
| . Create a compressed file from the `must-gather` directory that was just created in your working directory. Make sure you provide the date and cluster ID for a unique must-gather. For more information on how to find the cluster ID, see the Red Hat Knowledge base solution link:https://access.redhat.com/solutions/5280291[How to find the cluster-id or name on Opeshift cluster]. For example, on a computer that uses a Linux operating system, run the following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
modules/support-gather-data.adoc
Outdated
| $ tar cvaf must-gather-`date +"%m-%d-%Y-%H-%M-%S"`-$CLUSTERID.tar.gz must-gather.local.426787175854303238 <1> | ||
| ---- | ||
| <1> Make sure to replace `must-gather-local.5421342344627712289/` with the actual directory name. | ||
| <1> Make sure to replace `must-gather-local.426787175854303238/` with the actual directory name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
aa4f0ee to
d86b187
Compare
|
/cherrypick enterprise-4.16 |
|
/cherrypick enterprise-4.17 |
|
/cherrypick enterprise-4.18 |
|
/cherrypick enterprise-4.19 |
|
@xenolinux: #91615 failed to apply on top of branch "enterprise-4.12": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@xenolinux: #91615 failed to apply on top of branch "enterprise-4.13": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@xenolinux: new pull request created: #92393 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@xenolinux: new pull request created: #92394 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@xenolinux: new pull request created: #92395 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@xenolinux: new pull request created: #92396 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@xenolinux: #91615 failed to apply on top of branch "enterprise-4.18": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@xenolinux: new pull request created: #92397 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick enterprise-4.18 |
|
@xenolinux: new pull request created: #92398 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@wgabor0427 Automated cherry-picks for 4.12 and 4.13 failed. You need to create manual CP PRs. |
Version(s):
4.12+
Issue:
https://issues.redhat.com/browse/OCPBUGS-52653
Link to docs preview:
https://91615--ocpdocs-pr.netlify.app/openshift-dedicated/latest/support/gathering-cluster-data.html
https://91615--ocpdocs-pr.netlify.app/openshift-enterprise/latest/support/gathering-cluster-data.html
https://91615--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/support/gathering-cluster-data.html
https://91615--ocpdocs-pr.netlify.app/openshift-rosa/latest/support/gathering-cluster-data.html
QE review:
The following topic steps should have the same information: