HCIDOCS-373: Docs for OCPSTRAT-1425 Support additional NTP servers in install-config for bare metal (IPI) #86960
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@johnwilkins: This pull request references HCIDOCS-373 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/M
|
@johnwilkins: This pull request references HCIDOCS-373 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@johnwilkins: This pull request references HCIDOCS-373 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
johnwilkins
force-pushed
the
HCIDOCS-373
branch
from
19a4b65 to
d46fe74
Compare
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
xenolinux
added
peer-review-in-progress
There was a problem hiding this comment.
One comment otherwise LGTM
Per the following definitions, IMO the previous terms "bare-metal bridge" and "bare-metal network" were alright with hyphens.
https://redhat-documentation.github.io/supplementary-style-guide/#bare-metal-n
https://redhat-documentation.github.io/supplementary-style-guide/#bare-metal-adj
xenolinux
added
peer-review-done
There was a problem hiding this comment.
/lgtm
Thank you @johnwilkins
The 'optional parameter' table is not displaying as expected in the preview
|
|
@johnwilkins: This pull request references HCIDOCS-373 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
New changes are detected. LGTM label has been removed. |
johnwilkins
force-pushed
the
HCIDOCS-373
branch
from
63aaf13 to
f37e5b6
Compare
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
| @@ -175,7 +199,7 @@ a|`provisioningNetworkCIDR` | |||
| | | |||
| | The `provisioningNetwork` configuration setting determines whether the cluster uses the provisioning network. If it does, the configuration setting also determines if the cluster manages the network. | |||
|
|
|||
| `Disabled`: Set this parameter to `Disabled` to disable the requirement for a provisioning network. When set to `Disabled`, you must only use virtual media based provisioning, or bring up the cluster using the assisted installer. If `Disabled` and using power management, BMCs must be accessible from the bare-metal network. If `Disabled`, you must provide two IP addresses on the bare-metal network that are used for the provisioning services. | |||
| `Disabled`: Set this parameter to `Disabled` to disable the requirement for a provisioning network. When set to `Disabled`, you must only use virtual media based provisioning, or start the cluster by using the {ai-full}. If `Disabled` and using power management, BMCs must be accessible from the bare-metal network. If `Disabled`, you must provide two IP addresses on the bare-metal network that the installation program uses for the provisioning services. | |||
There was a problem hiding this comment.
🤖 [error] RedHat.TermsErrors: Use 'bare metal' rather than 'bare-metal'. For more information, see RedHat.TermsErrors.
| @@ -175,7 +199,7 @@ a|`provisioningNetworkCIDR` | |||
| | | |||
| | The `provisioningNetwork` configuration setting determines whether the cluster uses the provisioning network. If it does, the configuration setting also determines if the cluster manages the network. | |||
|
|
|||
| `Disabled`: Set this parameter to `Disabled` to disable the requirement for a provisioning network. When set to `Disabled`, you must only use virtual media based provisioning, or bring up the cluster using the assisted installer. If `Disabled` and using power management, BMCs must be accessible from the bare-metal network. If `Disabled`, you must provide two IP addresses on the bare-metal network that are used for the provisioning services. | |||
| `Disabled`: Set this parameter to `Disabled` to disable the requirement for a provisioning network. When set to `Disabled`, you must only use virtual media based provisioning, or start the cluster by using the {ai-full}. If `Disabled` and using power management, BMCs must be accessible from the bare-metal network. If `Disabled`, you must provide two IP addresses on the bare-metal network that the installation program uses for the provisioning services. | |||
There was a problem hiding this comment.
🤖 [error] RedHat.TermsErrors: Use 'bare metal' rather than 'bare-metal'. For more information, see RedHat.TermsErrors.
jeana-redhat
added
the
merge-review-in-progress
openshift-ci
bot
removed
merge-review-in-progress
…l config module, and to additional configuration settings module.
johnwilkins
force-pushed
the
HCIDOCS-373
branch
from
4c20d04 to
05a4a84
Compare
| @@ -175,7 +199,7 @@ a|`provisioningNetworkCIDR` | |||
| | | |||
| | The `provisioningNetwork` configuration setting determines whether the cluster uses the provisioning network. If it does, the configuration setting also determines if the cluster manages the network. | |||
|
|
|||
| `Disabled`: Set this parameter to `Disabled` to disable the requirement for a provisioning network. When set to `Disabled`, you must only use virtual media based provisioning, or bring up the cluster using the assisted installer. If `Disabled` and using power management, BMCs must be accessible from the bare-metal network. If `Disabled`, you must provide two IP addresses on the bare-metal network that are used for the provisioning services. | |||
| `Disabled`: Set this parameter to `Disabled` to disable the requirement for a provisioning network. When set to `Disabled`, you must only use virtual media based provisioning, or start the cluster by using the {ai-full}. If set to `Disabled` and using power management, BMCs must be accessible from the bare-metal network. If set to `Disabled`, you must provide two IP addresses on the bare-metal network that the installation program uses for the provisioning services. | |||
There was a problem hiding this comment.
🤖 [error] RedHat.TermsErrors: Use 'bare metal' rather than 'bare-metal'. For more information, see RedHat.TermsErrors.
| @@ -175,7 +199,7 @@ a|`provisioningNetworkCIDR` | |||
| | | |||
| | The `provisioningNetwork` configuration setting determines whether the cluster uses the provisioning network. If it does, the configuration setting also determines if the cluster manages the network. | |||
|
|
|||
| `Disabled`: Set this parameter to `Disabled` to disable the requirement for a provisioning network. When set to `Disabled`, you must only use virtual media based provisioning, or bring up the cluster using the assisted installer. If `Disabled` and using power management, BMCs must be accessible from the bare-metal network. If `Disabled`, you must provide two IP addresses on the bare-metal network that are used for the provisioning services. | |||
| `Disabled`: Set this parameter to `Disabled` to disable the requirement for a provisioning network. When set to `Disabled`, you must only use virtual media based provisioning, or start the cluster by using the {ai-full}. If set to `Disabled` and using power management, BMCs must be accessible from the bare-metal network. If set to `Disabled`, you must provide two IP addresses on the bare-metal network that the installation program uses for the provisioning services. | |||
There was a problem hiding this comment.
🤖 [error] RedHat.TermsErrors: Use 'bare metal' rather than 'bare-metal'. For more information, see RedHat.TermsErrors.
|
@johnwilkins: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.18 |
|
@jeana-redhat: new pull request created: #87139 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Added additionalNTPServers setting to install-config yaml config module, and to additional configuration settings module at line 26. The remaining changes are suggestions from the Vale linter.
Fixes: HCIDOCS-373
See https://issues.redhat.com/browse/HCIDOCS-373 for additional details.
Preview URL: https://86960--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/ipi/ipi-install-installation-workflow.html#configuring-the-install-config-file_ipi-install-installation-workflow and https://86960--ocpdocs-pr.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal/ipi/ipi-install-installation-workflow.html#additional-install-config-parameters_ipi-install-installation-workflow
For release(s): 4.18
QE Review:
Signed-off-by: [email protected]