-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[OSDOCS-13045] (Story) SDN to OVN Migration for ROSA Classic #86794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
55f3bf2 to
2815dbe
Compare
| == Additional resources | ||
|
|
||
| * link:https://access.redhat.com/articles/7065170[{OCP-short} SDN CNI removal in OCP 4.17] | ||
| * link:https://access.redhat.com/articles/7065170[{OCP-short} SDN CNI removal in OCP 4.17] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.CaseSensitiveTerms: Use 'Red Hat OpenShift Container Platform' rather than 'OCP'. For more information, see RedHat.CaseSensitiveTerms.
| @@ -0,0 +1,23 @@ | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] OpenShiftAsciiDoc.ModuleContainsContentType: Module is missing the '_mod-docs-content-type' variable.
a744c04 to
5c06a83
Compare
|
|
||
| toc::[] | ||
|
|
||
| Before upgrading to version 4.17, {product-title} clusters that are configured with the OpenShift SDN network plugin must migrate to the OVN-Kubernetes network plugin. You can perform the migration and check the migration status using the ROSA CLI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Cluster must be in 4.15.z. It's worthwhile to mention both in the introduction section and where the CLI command is provided.
- Other operations such as Cluster upgrade will not be allowed during the plugin migration.
- Mention that the migration can not be interrupted. Migrating back to SDN is not possible.
- Note that the cluster nodes will be rebooted during the migration. There will not be impact to workloads that are resilient to node disruptions.
- Migration can take several minutes or hours depending upon the cluster size, and workload configurations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very helpful, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for this info, @bchandra-ocp. Just so I am clear, for point #1, cluster must be version 4.15.z or above, correct? User could also do this for 4.16.z as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.15.22 and above ; or 4.16.24 and above
ab3fc90 to
e608920
Compare
| As a {rosa-classic-first} cluster administrator, you can initiate the migration from the OpenShift SDN network plugin to the OVN-Kubernetes network plugin as well as verify the migration status using the ROSA CLI. | ||
|
|
||
| // Before upgrading to version 4.17, you must migrate {rosa-classic-first} clusters that are configured with the OpenShift SDN network plugin to the OVN-Kubernetes network plugin. You can perform the migration and check the migration status using the ROSA CLI. | ||
| Some considerations prior to starting migration initiation are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [error] RedHat.TermsErrors: Use 'before' rather than 'prior to'. For more information, see RedHat.TermsErrors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the bot!
| Some considerations prior to starting migration initiation are: | |
| Some considerations before starting migration initiation are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bot wins! :)
a4a3035 to
f65e766
Compare
|
/label peer-review-in-progress |
modules/migrate-sdn-ovn.adoc
Outdated
| --subnet-configuration <configuration> <2> | ||
| ---- | ||
| <1> Replace `<cluster_id>` with the ID of the cluster you want to migrate to the OVN-Kubernetes network plugin. | ||
| <2> Replace `<configuration>` with the subnet configuration you want to use for your newly migrated OVN-Kubernetes cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An output example might be helpful here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. That should be (will be) added to docs once the developers decide the verbiage of the output.
AedinC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Mark - just a few very minor suggestions and thoughts!
/remove-label peer-review-in-progress
/label peer-review-done
/label lgtm
modules/migrate-sdn-ovn.adoc
Outdated
| To check the status of the migration, run the following command: | ||
| [source,terminal] | ||
| ---- | ||
| rosa describe cluster -c <cluster_id> <1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An output example would definitely be helpful here, and if not too much trouble, an explanation of the different migration statuses.
Is there a status for 'failed migration' and if so, what can user do to correct this- run the migration command again perhaps?
Also, regarding the migration time - is there any way to tell how long it will be? I see the time can vary between minutes to hours, but just trying to help the user realize when there might be a problem- this might not be possible. Just a few thoughts!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good points! Will dig around and see if I can find if devs have that info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AedinC Did some digging and found this...so going to assume that the state object will provide the info you mentioned...but will verify once OCM-11595 is completed.

|
|
||
| toc::[] | ||
|
|
||
| As a {rosa-classic-first} cluster administrator, you can initiate the migration from the OpenShift SDN network plugin to the OVN-Kubernetes network plugin as well as verify the migration status using the ROSA CLI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be helpful to mention that OpenShift SDN network plugin was deprecated in 4.14 and removed in 4.17 and link to OCP release note: https://docs.redhat.com/en/documentation/openshift_container_platform/4.14/html-single/release_notes/index#ocp-4-14-deprecation-sdn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That info was listed here: https://86794--ocpdocs-pr.netlify.app/openshift-rosa/latest/networking/about-managed-networking but no link was created. I believe there was a reason I didn't duplicate that info in this location but now I need to remember why :(
| As a {rosa-classic-first} cluster administrator, you can initiate the migration from the OpenShift SDN network plugin to the OVN-Kubernetes network plugin as well as verify the migration status using the ROSA CLI. | ||
|
|
||
| // Before upgrading to version 4.17, you must migrate {rosa-classic-first} clusters that are configured with the OpenShift SDN network plugin to the OVN-Kubernetes network plugin. You can perform the migration and check the migration status using the ROSA CLI. | ||
| Some considerations prior to starting migration initiation are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the bot!
| Some considerations prior to starting migration initiation are: | |
| Some considerations before starting migration initiation are: |
|
|
||
| toc::[] | ||
|
|
||
| As a {rosa-classic-first} cluster administrator, you can initiate the migration from the OpenShift SDN network plugin to the OVN-Kubernetes network plugin as well as verify the migration status using the ROSA CLI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| As a {rosa-classic-first} cluster administrator, you can initiate the migration from the OpenShift SDN network plugin to the OVN-Kubernetes network plugin as well as verify the migration status using the ROSA CLI. | |
| As a {rosa-classic-first} cluster administrator, you can initiate the migration from the OpenShift SDN network plugin to the OVN-Kubernetes network plugin and verify the migration status using the ROSA CLI. |
modules/migrate-sdn-ovn.adoc
Outdated
| ---- | ||
| rosa describe cluster -c <cluster_id> <1> | ||
| ---- | ||
| <1> Replace `<cluster_id>` with the ID of the cluster to check migration status. No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <1> Replace `<cluster_id>` with the ID of the cluster to check migration status. | |
| <1> Replace `<cluster_id>` with the ID of the cluster to check the migration status. |
83a530e to
3d17f64
Compare
hunterkepley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments to change --migrate-network-type to --network-type - thanks Mark
modules/migrate-sdn-ovn.adoc
Outdated
| [source,terminal] | ||
| ---- | ||
| $ rosa edit cluster -c <cluster_id> <1> | ||
| --migrate-network-type OVNKubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--network-type
modules/migrate-sdn-ovn.adoc
Outdated
|
|
||
| [IMPORTANT] | ||
| ==== | ||
| You cannot include the optional flag `--ovn-internal-subnets` in the command unless you define a value for the flag `--migrate-network-type`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--network-type
Sorry for the confusion earlier, I was confused as well since it was requested to change this back and forth
hunterkepley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one small change but that's it
modules/migrate-sdn-ovn.adoc
Outdated
| --ovn-internal-subnets <configuration> <2> | ||
| ---- | ||
| <1> Replace `<cluster_id>` with the ID of the cluster you want to migrate to the OVN-Kubernetes network plugin. | ||
| <2> Optional: Users can create key-value pairs to configure internal subnets using any or all of the options `join, masquerade, transit` along with a single CIDR per option. For example, `--ovn-subnet-configuration="join=0.0.0.0/24,transit=0.0.0.0/24,masquerade=0.0.0.0/24"`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--ovn-subnet-configuration -> --ovn-internal-subnets
e4f0b08 to
fc6b40d
Compare
|
|
||
| Some considerations before starting migration initiation are: | ||
|
|
||
| * The cluster version must be 4.15.22 and above or 4.16.24 and above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cluster version 4.15 req has been removed and only 4.16.24+ is supported now.
cc4288a to
694dd16
Compare
|
/lgtm |
c2540d3 to
4b168b8
Compare
|
New changes are detected. LGTM label has been removed. |
868472a to
054053c
Compare
054053c to
e99c306
Compare
EricPonvelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small fix, but not worth blocking merge.
modules/migrate-sdn-ovn.adoc
Outdated
| To check the status of the migration, run the following command: | ||
| [source,terminal] | ||
| ---- | ||
| rosa describe cluster -c <cluster_id> <1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| rosa describe cluster -c <cluster_id> <1> | |
| $ rosa describe cluster -c <cluster_id> <1> |
rosa_release_notes/rosa-release-notes.adoc
e99c306 to
400e443
Compare
|
@mletalie: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.17 |
|
/cherrypick enterprise-4.18 |
|
@EricPonvelle: new pull request created: #88512 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@EricPonvelle: new pull request created: #88513 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |


Version(s):
4.17+
Issue:
https://issues.redhat.com/browse/OSDOCS-13045
QE Review ticket: https://issues.redhat.com/browse/OSDOCS-13168
Link to docs preview:
QE review:
https://86794--ocpdocs-pr.netlify.app/openshift-rosa/latest/networking/ovn_kubernetes_network_provider/migrate-from-openshift-sdn.html
https://86794--ocpdocs-pr.netlify.app/openshift-rosa/latest/networking/about-managed-networking.html
Additional information: