Skip to content

Conversation

@mletalie
Copy link
Contributor

@mletalie mletalie commented Jan 7, 2025

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 7, 2025
@mletalie mletalie changed the title Osdocs 13045 [OSDOCS-13045] (Story) SDN to OVN Migration for ROSA Classic Jan 8, 2025
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2025
== Additional resources

* link:https://access.redhat.com/articles/7065170[{OCP-short} SDN CNI removal in OCP 4.17]
* link:https://access.redhat.com/articles/7065170[{OCP-short} SDN CNI removal in OCP 4.17]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.CaseSensitiveTerms: Use 'Red Hat OpenShift Container Platform' rather than 'OCP'. For more information, see RedHat.CaseSensitiveTerms.

@@ -0,0 +1,23 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] OpenShiftAsciiDoc.ModuleContainsContentType: Module is missing the '_mod-docs-content-type' variable.

@mletalie mletalie force-pushed the OSDOCS-13045 branch 7 times, most recently from a744c04 to 5c06a83 Compare January 14, 2025 01:52

toc::[]

Before upgrading to version 4.17, {product-title} clusters that are configured with the OpenShift SDN network plugin must migrate to the OVN-Kubernetes network plugin. You can perform the migration and check the migration status using the ROSA CLI.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This statement is repeating. Perhaps we leave out "You can perform the migration and check the migration status using the ROSA CLI." here?
image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Cluster must be in 4.15.z. It's worthwhile to mention both in the introduction section and where the CLI command is provided.
  2. Other operations such as Cluster upgrade will not be allowed during the plugin migration.
  3. Mention that the migration can not be interrupted. Migrating back to SDN is not possible.
  4. Note that the cluster nodes will be rebooted during the migration. There will not be impact to workloads that are resilient to node disruptions.
  5. Migration can take several minutes or hours depending upon the cluster size, and workload configurations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very helpful, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for this info, @bchandra-ocp. Just so I am clear, for point #1, cluster must be version 4.15.z or above, correct? User could also do this for 4.16.z as well?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.15.22 and above ; or 4.16.24 and above

@mletalie
Copy link
Contributor Author

image
Currently published doc that uses similar bulleted item format.

As a {rosa-classic-first} cluster administrator, you can initiate the migration from the OpenShift SDN network plugin to the OVN-Kubernetes network plugin as well as verify the migration status using the ROSA CLI.

// Before upgrading to version 4.17, you must migrate {rosa-classic-first} clusters that are configured with the OpenShift SDN network plugin to the OVN-Kubernetes network plugin. You can perform the migration and check the migration status using the ROSA CLI.
Some considerations prior to starting migration initiation are:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.TermsErrors: Use 'before' rather than 'prior to'. For more information, see RedHat.TermsErrors.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the bot!

Suggested change
Some considerations prior to starting migration initiation are:
Some considerations before starting migration initiation are:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot wins! :)

@AedinC
Copy link
Contributor

AedinC commented Jan 16, 2025

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jan 16, 2025
--subnet-configuration <configuration> <2>
----
<1> Replace `<cluster_id>` with the ID of the cluster you want to migrate to the OVN-Kubernetes network plugin.
<2> Replace `<configuration>` with the subnet configuration you want to use for your newly migrated OVN-Kubernetes cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An output example might be helpful here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. That should be (will be) added to docs once the developers decide the verbiage of the output.

Copy link
Contributor

@AedinC AedinC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Mark - just a few very minor suggestions and thoughts!
/remove-label peer-review-in-progress
/label peer-review-done
/label lgtm

To check the status of the migration, run the following command:
[source,terminal]
----
rosa describe cluster -c <cluster_id> <1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An output example would definitely be helpful here, and if not too much trouble, an explanation of the different migration statuses.
Is there a status for 'failed migration' and if so, what can user do to correct this- run the migration command again perhaps?
Also, regarding the migration time - is there any way to tell how long it will be? I see the time can vary between minutes to hours, but just trying to help the user realize when there might be a problem- this might not be possible. Just a few thoughts!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good points! Will dig around and see if I can find if devs have that info.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AedinC Did some digging and found this...so going to assume that the state object will provide the info you mentioned...but will verify once OCM-11595 is completed.
image


toc::[]

As a {rosa-classic-first} cluster administrator, you can initiate the migration from the OpenShift SDN network plugin to the OVN-Kubernetes network plugin as well as verify the migration status using the ROSA CLI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be helpful to mention that OpenShift SDN network plugin was deprecated in 4.14 and removed in 4.17 and link to OCP release note: https://docs.redhat.com/en/documentation/openshift_container_platform/4.14/html-single/release_notes/index#ocp-4-14-deprecation-sdn?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That info was listed here: https://86794--ocpdocs-pr.netlify.app/openshift-rosa/latest/networking/about-managed-networking but no link was created. I believe there was a reason I didn't duplicate that info in this location but now I need to remember why :(

As a {rosa-classic-first} cluster administrator, you can initiate the migration from the OpenShift SDN network plugin to the OVN-Kubernetes network plugin as well as verify the migration status using the ROSA CLI.

// Before upgrading to version 4.17, you must migrate {rosa-classic-first} clusters that are configured with the OpenShift SDN network plugin to the OVN-Kubernetes network plugin. You can perform the migration and check the migration status using the ROSA CLI.
Some considerations prior to starting migration initiation are:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the bot!

Suggested change
Some considerations prior to starting migration initiation are:
Some considerations before starting migration initiation are:


toc::[]

As a {rosa-classic-first} cluster administrator, you can initiate the migration from the OpenShift SDN network plugin to the OVN-Kubernetes network plugin as well as verify the migration status using the ROSA CLI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
As a {rosa-classic-first} cluster administrator, you can initiate the migration from the OpenShift SDN network plugin to the OVN-Kubernetes network plugin as well as verify the migration status using the ROSA CLI.
As a {rosa-classic-first} cluster administrator, you can initiate the migration from the OpenShift SDN network plugin to the OVN-Kubernetes network plugin and verify the migration status using the ROSA CLI.

----
rosa describe cluster -c <cluster_id> <1>
----
<1> Replace `<cluster_id>` with the ID of the cluster to check migration status. No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<1> Replace `<cluster_id>` with the ID of the cluster to check migration status.
<1> Replace `<cluster_id>` with the ID of the cluster to check the migration status.

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jan 16, 2025
Copy link

@hunterkepley hunterkepley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments to change --migrate-network-type to --network-type - thanks Mark

[source,terminal]
----
$ rosa edit cluster -c <cluster_id> <1>
--migrate-network-type OVNKubernetes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--network-type


[IMPORTANT]
====
You cannot include the optional flag `--ovn-internal-subnets` in the command unless you define a value for the flag `--migrate-network-type`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--network-type

Sorry for the confusion earlier, I was confused as well since it was requested to change this back and forth

Copy link

@hunterkepley hunterkepley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small change but that's it

--ovn-internal-subnets <configuration> <2>
----
<1> Replace `<cluster_id>` with the ID of the cluster you want to migrate to the OVN-Kubernetes network plugin.
<2> Optional: Users can create key-value pairs to configure internal subnets using any or all of the options `join, masquerade, transit` along with a single CIDR per option. For example, `--ovn-subnet-configuration="join=0.0.0.0/24,transit=0.0.0.0/24,masquerade=0.0.0.0/24"`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--ovn-subnet-configuration -> --ovn-internal-subnets

@mletalie mletalie force-pushed the OSDOCS-13045 branch 2 times, most recently from e4f0b08 to fc6b40d Compare January 22, 2025 20:37

Some considerations before starting migration initiation are:

* The cluster version must be 4.15.22 and above or 4.16.24 and above.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cluster version 4.15 req has been removed and only 4.16.24+ is supported now.

@jfrazierRH
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jan 29, 2025

New changes are detected. LGTM label has been removed.

@mletalie mletalie force-pushed the OSDOCS-13045 branch 2 times, most recently from 868472a to 054053c Compare January 29, 2025 18:23
Copy link
Contributor

@EricPonvelle EricPonvelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fix, but not worth blocking merge.

To check the status of the migration, run the following command:
[source,terminal]
----
rosa describe cluster -c <cluster_id> <1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rosa describe cluster -c <cluster_id> <1>
$ rosa describe cluster -c <cluster_id> <1>

	rosa_release_notes/rosa-release-notes.adoc
@openshift-ci
Copy link

openshift-ci bot commented Feb 12, 2025

@mletalie: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@EricPonvelle EricPonvelle merged commit 0784cf1 into openshift:main Feb 12, 2025
2 checks passed
@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.17

@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.18

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #88512

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #88513

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.17 branch/enterprise-4.18 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants