OADP-4454: Fixing configuration error in Azure installation docs

[anarnold97]

JIRA

• OADP-4454

I have reworked the logic for OADP to remove the Azure CLI commands

Versions

• OCP 4.12 → branch/enterprise-4.12
• OCP 4.13 → branch/enterprise-4.13
• OCP 4.14 → branch/enterprise-4.14
• OCP 4.15 → branch/enterprise-4.15
• OCP 4.16 → branch/enterprise-4.16

Link to docs preview:

OADP preview:

• Configuring Microsoft Azure

MTC docs impacted:

• MTC - Configuring Microsoft Azure
• Installing the Migration Toolkit for Containers - Configuring Microsoft Azure

QE review:

• QE has approved this change. Amos Mastbaum approved (LGTM in JIRA)

Additional information:

[openshift-ci-robot]

@anarnold97: This pull request references OADP-4454 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@anarnold97: This pull request references OADP-4454 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ocpdocs-previewbot]

🤖 Fri Sep 13 13:42:12 - Prow CI generated the docs preview:

https://78670--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/installing-oadp-azure.html
https://78670--ocpdocs-pr.netlify.app/openshift-enterprise/latest/migrating_from_ocp_3_to_4/installing-3-4.html
https://78670--ocpdocs-pr.netlify.app/openshift-enterprise/latest/migration_toolkit_for_containers/installing-mtc.html

[openshift-ci-robot]

@anarnold97: This pull request references OADP-4454 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

Details

In response to this:

JIRA

• OADP-4454

Versions

• OCP 4.12 → branch/enterprise-4.12
• OCP 4.13 → branch/enterprise-4.13
• OCP 4.14 → branch/enterprise-4.14
• OCP 4.15 → branch/enterprise-4.15
• OCP 4.16 → branch/enterprise-4.16

Link to docs preview:

OADP preview:

• Configuring Microsoft Azure

MTC docs impacted:

• MTC - Configuring Microsoft Azure
• Installing the Migration Toolkit for Containers - Configuring Microsoft Azure

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@anarnold97: This pull request references OADP-4454 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

Details

In response to this:

JIRA

• OADP-4454

I have used the Azure CLI docs to bring across the --scopes parameter.

I have included:

• Subscription: /subscriptions/mySubscriptionID
• Resource group: /subscriptions/mySubscriptionID/resourceGroups/myResourceGroupName

I presume this is correct but do not have an Azure instance to test.

I have changed these to lowercase Snake Case, although I think there is a good argument to keep them in MS formatting of Camel Case.

Versions

• OCP 4.12 → branch/enterprise-4.12
• OCP 4.13 → branch/enterprise-4.13
• OCP 4.14 → branch/enterprise-4.14
• OCP 4.15 → branch/enterprise-4.15
• OCP 4.16 → branch/enterprise-4.16

Link to docs preview:

OADP preview:

• Configuring Microsoft Azure

MTC docs impacted:

• MTC - Configuring Microsoft Azure
• Installing the Migration Toolkit for Containers - Configuring Microsoft Azure

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[amastbau]

@anarnold97
seems like section 11 and 14 are duplicated
i think you only wnat to leave 14

[anarnold97]

@anarnold97 seems like section 11 and 14 are duplicated i think you only wnat to leave 14

@amastbau - which is really weird as I only added section 9 and 10! LOL

[anarnold97]

@amastbau - i think it is caused by a missing ifdef.

So if we change lines 117 to 134 and include an ifndef not to include installing-oadp-azure variable, which should pair with the ifdef to include installing-oadp-azure variable.

Please can you check again.

[openshift-ci-robot]

@anarnold97: This pull request references OADP-4454 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

Details

In response to this:

JIRA

• OADP-4454

I have used the Azure CLI docs to bring across the --scopes parameter.

I have included:

• Subscription: /subscriptions/mySubscriptionID
• Resource group: /subscriptions/mySubscriptionID/resourceGroups/myResourceGroupName

I presume this is correct but do not have an Azure instance to test.

I have changed these to lowercase Snake Case, although I think there is a good argument to keep them in MS formatting of Camel Case.

Versions

• OCP 4.12 → branch/enterprise-4.12
• OCP 4.13 → branch/enterprise-4.13
• OCP 4.14 → branch/enterprise-4.14
• OCP 4.15 → branch/enterprise-4.15
• OCP 4.16 → branch/enterprise-4.16

Link to docs preview:

OADP preview:

• Configuring Microsoft Azure

MTC docs impacted:

• MTC - Configuring Microsoft Azure
• Installing the Migration Toolkit for Containers - Configuring Microsoft Azure

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@anarnold97: This pull request references OADP-4454 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

Details

In response to this:

JIRA

• OADP-4454

I have used the Azure CLI docs to bring across the --scopes parameter.

I have included:

• Subscription: /subscriptions/mySubscriptionID
• Resource group: /subscriptions/mySubscriptionID/resourceGroups/myResourceGroupName

I presume this is correct but do not have an Azure instance to test.

I have changed these to lowercase Snake Case, although I think there is a good argument to keep them in MS formatting of Camel Case.

Versions

• OCP 4.12 → branch/enterprise-4.12
• OCP 4.13 → branch/enterprise-4.13
• OCP 4.14 → branch/enterprise-4.14
• OCP 4.15 → branch/enterprise-4.15
• OCP 4.16 → branch/enterprise-4.16

Link to docs preview:

OADP preview:

• Configuring Microsoft Azure

MTC docs impacted:

• MTC - Configuring Microsoft Azure
• Installing the Migration Toolkit for Containers - Configuring Microsoft Azure

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@anarnold97: This pull request references OADP-4454 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

Details

In response to this:

JIRA

• OADP-4454

I have used the Azure CLI docs to bring across the --scopes parameter.

I have included:

• Subscription: /subscriptions/mySubscriptionID
• Resource group: /subscriptions/mySubscriptionID/resourceGroups/myResourceGroupName

I presume this is correct but do not have an Azure instance to test.

I have changed these to lowercase Snake Case, although I think there is a good argument to keep them in MS formatting of Camel Case.

Versions

• OCP 4.12 → branch/enterprise-4.12
• OCP 4.13 → branch/enterprise-4.13
• OCP 4.14 → branch/enterprise-4.14
• OCP 4.15 → branch/enterprise-4.15
• OCP 4.16 → branch/enterprise-4.16

Link to docs preview:

OADP preview:

• Configuring Microsoft Azure

MTC docs impacted:

• MTC - Configuring Microsoft Azure
• Installing the Migration Toolkit for Containers - Configuring Microsoft Azure

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@anarnold97: This pull request references OADP-4454 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

Details

In response to this:

JIRA

• OADP-4454

Versions

• OCP 4.12 → branch/enterprise-4.12
• OCP 4.13 → branch/enterprise-4.13
• OCP 4.14 → branch/enterprise-4.14
• OCP 4.15 → branch/enterprise-4.15
• OCP 4.16 → branch/enterprise-4.16

Link to docs preview:

OADP preview:

• Configuring Microsoft Azure

MTC docs impacted:

• MTC - Configuring Microsoft Azure
• Installing the Migration Toolkit for Containers - Configuring Microsoft Azure

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@anarnold97: This pull request references OADP-4454 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

Details

In response to this:

JIRA

• OADP-4454

I have reworked the logic for OADP to remove the Azure CLI commands

Versions

• OCP 4.12 → branch/enterprise-4.12
• OCP 4.13 → branch/enterprise-4.13
• OCP 4.14 → branch/enterprise-4.14
• OCP 4.15 → branch/enterprise-4.15
• OCP 4.16 → branch/enterprise-4.16

Link to docs preview:

OADP preview:

• Configuring Microsoft Azure

MTC docs impacted:

• MTC - Configuring Microsoft Azure
• Installing the Migration Toolkit for Containers - Configuring Microsoft Azure

QE review:

• QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[anarnold97]

/label oadp

[openshift-ci]

@anarnold97: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[anarnold97]

squashed ready for merge review

[anarnold97]

/label merge-review-needed

[stevsmit]

A few smaller nits, like preceding all ocmmands with ". . . by entering the following command:", but nothing that should hold up a review. Good work.

[stevsmit]

Suggested change

	. After creating the service principal, obtain the client id.
	. After creating the service principal, obtain the client id:

[stevsmit]

/cherry-pick enterprise-4.12

[stevsmit]

/cherry-pick enterprise-4.13

[stevsmit]

/cherry-pick enterprise-4.14

[stevsmit]

/cherry-pick enterprise-4.15

[stevsmit]

/cherry-pick enterprise-4.16

[stevsmit]

/cherry-pick enterprise-4.17

[openshift-cherrypick-robot]

@stevsmit: #78670 failed to apply on top of branch "enterprise-4.12":

Applying: OADP-4454: Fixing configuration error in Azure installation docs
Using index info to reconstruct a base tree...
M	modules/migration-configuring-azure.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/migration-configuring-azure.adoc
CONFLICT (content): Merge conflict in modules/migration-configuring-azure.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OADP-4454: Fixing configuration error in Azure installation docs
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@stevsmit: new pull request created: #81901

Details

In response to this:

/cherry-pick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@stevsmit: new pull request created: #81902

Details

In response to this:

/cherry-pick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@stevsmit: new pull request created: #81903

Details

In response to this:

/cherry-pick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@stevsmit: new pull request created: #81904

Details

In response to this:

/cherry-pick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@stevsmit: new pull request created: #81905

Details

In response to this:

/cherry-pick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[stevsmit]

/retest