Skip to content

Conversation

@lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Jun 3, 2024

@lpettyjo lpettyjo added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 3, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2024
@lpettyjo lpettyjo added branch/enterprise-4.15 and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 3, 2024
@lpettyjo lpettyjo added this to the Continuous Release milestone Jun 3, 2024
@lpettyjo lpettyjo requested a review from gnufied June 3, 2024 23:38
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 3, 2024
@ocpdocs-previewbot
Copy link

@openshift-ci
Copy link

openshift-ci bot commented Jun 3, 2024

@lpettyjo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@xenolinux
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Jun 4, 2024
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

LGTM

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Jun 4, 2024
@gcharot
Copy link

gcharot commented Jun 4, 2024

LGTM
@gnufied can you please review? Thanks!

@gnufied
Copy link
Member

gnufied commented Jun 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024
@duanwei33
Copy link

Hi @gnufied
In 4.15, I recall we reverted it to 3.0.2 due to topology bug in this PR(openshift/vmware-vsphere-csi-driver#101), could you double check? I don't know how to check that from the code.

@gnufied
Copy link
Member

gnufied commented Jul 23, 2024

@duanwei33 you are actually right. I think version of vSphere CSI driver didn't change.

@lpettyjo lpettyjo closed this Aug 5, 2024
@lpettyjo
Copy link
Contributor Author

lpettyjo commented Aug 5, 2024

Since the version didn't actually change, I'm closing this PR without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.15 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants