Skip to content

Conversation

@dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Apr 29, 2024

Cherry pick from #74339 with commit ID cbb655c

Versions:
4.12

Issue:
OCPBUGS-29262

Link to docs preview:

NOTE: As per #70551, the Agent-based installer only apply to 4.15+.

One parameter missing:

image

The following vCentre parameters were not live until 4.13. So vCenter is OK for 4.12 , so the following parameters are not applicable to 4.12:

  • platform.vsphere.vcenters.password
  • platform.vsphere.vcenters.port
  • platform.vsphere.vcenters.server
  • platform.vsphere.vcenters.user

See https://issues.redhat.com/browse/OCPBUGS-29262

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2024
@dfitzmau dfitzmau changed the title OCPBUGS-29262-redo: Updated the vSphere add parameters to include mis… [enterprise-4.12] OCPBUGS-29262-412: Updated the vSphere add parameters to include mis… Apr 29, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 29, 2024
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-29262, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Release Pending (Done) instead
  • expected Jira Issue OCPBUGS-29262 to depend on a bug in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

…sing parameters

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau dfitzmau force-pushed the OCPBUGS-29262-412 branch from 436563f to d099f0c Compare April 29, 2024 09:55
@ocpdocs-previewbot
Copy link

🤖 Mon Apr 29 10:00:17 - Prow CI generated the docs preview:
https://75241--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci
Copy link

openshift-ci bot commented Apr 29, 2024

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dfitzmau
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 29, 2024
@JoeAldinger JoeAldinger added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 29, 2024
@JoeAldinger JoeAldinger merged commit c5fa8d5 into openshift:enterprise-4.12 Apr 29, 2024
@openshift-ci-robot
Copy link

@dfitzmau: Jira Issue OCPBUGS-29262 is in an unrecognized state (Release Pending) and will not be moved to the MODIFIED state.

Details

In response to this:

Cherry pick from #74339 with commit ID cbb655c

Versions:
4.12

Issue:
OCPBUGS-29262

Link to docs preview:

NOTE: As per #70551, the Agent-based installer only apply to 4.15+.

One parameter missing:

image

The following vCentre parameters were not live until 4.13. So vCenter is OK for 4.12 , so the following parameters are not applicable to 4.12:

  • platform.vsphere.vcenters.password
  • platform.vsphere.vcenters.port
  • platform.vsphere.vcenters.server
  • platform.vsphere.vcenters.user

See https://issues.redhat.com/browse/OCPBUGS-29262

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoeAldinger JoeAldinger removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants