-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[internal-fix] fix-vsphere-datastore-ifdef #75240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[internal-fix] fix-vsphere-datastore-ifdef #75240
Conversation
|
🤖 Mon Apr 29 09:29:24 - Prow CI generated the docs preview: |
|
@dfitzmau: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/label peer-review-needed |
|
/lgtm |
|
/label merge-review-needed |
|
/cherrypick enterprise-4.15 |
|
/cherrypick enterprise-4.16 |
|
@mburke5678: new pull request created: #75266 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #75267 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Purpose:
An ifdef statement has broken the table at the
datastoreparameter entry in the vSphere docs. See CP link. The issue does not impact docs.openshift.com nor the on-premise Agent-based Installer docs. Suggestion: do not let two ifdef statements shared the same table entry.Version(s):
4.16 and 4.15 as the vSphere parameters were added to the on-premise Agent-based docs at 4.15. See link.
Issue:
OCPBUGS-29262
Link to docs preview: