Skip to content

OSDOCS-9499# RWOP TP -> GA #73710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lpettyjo merged 1 commit into from
Jun 12, 2024
Merged

OSDOCS-9499# RWOP TP -> GA #73710

lpettyjo merged 1 commit into from
Jun 12, 2024

Conversation

@lpettyjo
Copy link
Contributor

@lpettyjo lpettyjo commented Mar 25, 2024 •
edited
Loading

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 25, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 25, 2024 •
edited
Loading

🤖 Fri Jun 07 17:39:22 - Prow CI generated the docs preview:

https://73710--ocpdocs-pr.netlify.app/microshift/latest/microshift_storage/understanding-persistent-storage-microshift.html
https://73710--ocpdocs-pr.netlify.app/openshift-dedicated/latest/storage/understanding-persistent-storage.html
https://73710--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/understanding-persistent-storage.html
https://73710--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/understanding-persistent-storage.html

@lpettyjo lpettyjo added branch/enterprise-4.16 peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 25, 2024
@lpettyjo lpettyjo added this to the Planned for 4.16 GA milestone Mar 25, 2024
@mramendi
Copy link
Contributor

mramendi commented Mar 25, 2024

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 25, 2024
mramendi
mramendi approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@mramendi mramendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one nit, and it might be out of scope. As I am in peer review induction, @JoeAldinger will finish this review

Also: I assume you did get QE approval for this? Ideally please mark in a comment who in QE approved the change. We do have to get QE approval for anything except pure editorial change.

JoeAldinger
JoeAldinger reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@JoeAldinger JoeAldinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion for CI item while you are here. Otherwise, lgtm

@JoeAldinger JoeAldinger added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 25, 2024
mletalie
mletalie reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label peer-review-needed

@openshift-ci openshift-ci bot removed the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 25, 2024
@jsafrane
Copy link
Contributor

jsafrane commented Mar 28, 2024

lgtm

@radeore
Copy link

radeore commented Apr 12, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024
@jsafrane
Copy link
Contributor

jsafrane commented Apr 15, 2024

lgtm

1 similar comment
@gcharot
Copy link

gcharot commented Apr 23, 2024

lgtm

gcharot
gcharot reviewed May 6, 2024
View reviewed changes
@gcharot
Copy link

gcharot commented May 6, 2024

lgtm as it is but do we want to add selinux context mount note as part of this doc PR?

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
@openshift-ci
Copy link

openshift-ci bot commented May 10, 2024

New changes are detected. LGTM label has been removed.

@lpettyjo
Copy link
Contributor Author

lpettyjo commented May 10, 2024

SELinux content added for https://issues.redhat.com/browse/STOR-1464. @jsafrane @radeore @gcharot please review new content. Thanks!

gcharot
gcharot reviewed May 13, 2024
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jun 3, 2024
View reviewed changes
@lpettyjo
Copy link
Contributor Author

lpettyjo commented Jun 3, 2024

@jsafrane, @chao007, @gcharot "EBS" changed to "AWS EBS" and ODF added. PTAL one last time!

@chao007
Copy link

chao007 commented Jun 4, 2024

lgtm

gcharot
gcharot reviewed Jun 6, 2024
View reviewed changes
@lpettyjo
Copy link
Contributor Author

lpettyjo commented Jun 7, 2024

/retest

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jun 7, 2024
View reviewed changes
@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2024

@lpettyjo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau dfitzmau mentioned this pull request Jun 11, 2024
Merged
1 task
@jsafrane
Copy link
Contributor

jsafrane commented Jun 11, 2024

Lgtm

@lpettyjo lpettyjo merged commit 2033ee2 into openshift:main Jun 12, 2024
@lpettyjo
Copy link
Contributor Author

lpettyjo commented Jun 12, 2024

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 12, 2024

@lpettyjo: new pull request created: #77369

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoeAldinger JoeAldinger JoeAldinger left review comments

@mletalie mletalie mletalie left review comments

+4 more reviewers

@gcharot gcharot gcharot left review comments

@chao007 chao007 chao007 left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@mramendi mramendi mramendi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@radeore radeore

Labels

branch/enterprise-4.16 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.16 GA

Development

Successfully merging this pull request may close these issues.