added registry console section per BZ #7331
Conversation
openshift-ci-robot
added
the
size/M
|
@tripledes I am not clear on the |
|
@tripledes PTAL |
|
@mburke5678 LGTM, @jtudelag works? |
jtudelag
left a comment
jtudelag
left a comment
There was a problem hiding this comment.
@mburke5678 @tripledes Please review ;)
|
|
||
| For example: | ||
| ---- | ||
| openshift_cockpit_deployer_prefix='registry.example.com/openshift' |
There was a problem hiding this comment.
This example does not match the variable format <registry>/<namespace>/<cockpit-image-name>. The <cockpit-image-name> is missing... https://github.com/openshift/openshift-docs/pull/7331/files#diff-fe94157edddadf88425cf07b556a00a3R794
Shouldn't it be openshift_cockpit_deployer_prefix='registry.example.com/openshift/console instead?
@tripledes @mburke5678 please review!!
There was a problem hiding this comment.
Based on https://github.com/openshift/openshift-ansible/blob/release-3.6/inventory/byo/hosts.ose.example#L416-L423 I'd say what @mburke5678 is correct. @mburke5678 could you please ping anyone from openshift-ansible to confirm?
There was a problem hiding this comment.
@sdodson Can you help? We are trying to determine an appropriate example for the openshift_cockpit_deployer_prefix parameter.
openshift_cockpit_deployer_prefix='registry.example.com/openshift'
openshift_cockpit_deployer_prefix='registry.example.com/openshift/console'
Other?
There was a problem hiding this comment.
If your image is at registry.example.com/openshift3/registry-console then it should be openshift_cockpit_deployer_prefix='registry.example.com/openshift3/' as registry-console is appended on to the end, though that too can be modified via openshift_cockpit_deployer_basename
|
@jianlinliu PTAL |
|
|
||
| ---- | ||
| openshift_cockpit_deployer_prefix=<registry-name>/<namespace>/ | ||
| openshift_cockpit_deployer_basename=<my-console> |
There was a problem hiding this comment.
This PR is targeted for 3.7, right? If yes, then it is okay. "openshift_cockpit_deployer_basename" is not supported yet in 3.6 openshift-ansible code yet.
| version 1.4.1, enter: | ||
| ---- | ||
| openshift_cockpit_deployer_prefix='registry.example.com/openshift3/' | ||
| openshift_cockpit_deployer_basename=`registry-console` |
There was a problem hiding this comment.
"registry-console" is the default value, in this example, it is better to change it to other than the default name
|
@tripledes Can you comment on @jianlinliu comment about which version that |
mburke5678
force-pushed
the
BZ-1518204
branch
2 times, most recently
from
9ac309c to
43fe698
Compare
|
[rev_history] |
|
@openshift/team-documentation PTAL as we settle on versioning. |
|
LGTM. |
mburke5678
force-pushed
the
BZ-1518204
branch
from
df16ead to
07b256d
Compare
|
@openshift/team-documentation PTAL |
|
@mburke LGTM. In the revision history, you just need to update the first line to show: |
ahardin-rh
added
the
peer-review-done
(cherry picked from commit 07b256d) xref:openshift#7331
(cherry picked from commit 07b256d) xref:openshift#7331
| openshift_docker_additional_registries=example.com | ||
| ---- | ||
|
|
||
| [[advanced-install-configuring-registry-location]] |
There was a problem hiding this comment.
@mburke5678 this is a duplicate id, which seems to be copied from the previous section. I have changed it to advanced-install-configuring-registry-console.
|
@mburke5678 - the rev history link to the section id was not correct. Instead of configuring-a-registry-location it should have been advanced-install-configuring-registry-console. |
8 participants
https://bugzilla.redhat.com/show_bug.cgi?id=1518204