Skip to content

OCDOCS#3995: Port security and compliance content to the ROSA doc set #72837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tmalove wants to merge 5 commits into from
Closed

OCDOCS#3995: Port security and compliance content to the ROSA doc set #72837

tmalove wants to merge 5 commits into from

Conversation

@tmalove
Copy link
Contributor

@tmalove tmalove commented Mar 7, 2024 •
edited
Loading

Version(s):
4.15+

Issue:
OSDOCS-3995

Link to docs preview: (https://72837--ocpdocs-pr.netlify.app/openshift-rosa/latest/security/#security-overview) (Updated 3/18/24) VPN required.

QE review:

  • QE has approved this change.

Additional information:
The original PR was based on 4.13. The most efficient way to get these updates in a PR based on 'main' was to start a new PR and add the changes.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 7, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 7, 2024 •
edited
Loading

🤖 Fri May 31 23:35:16 - Prow CI generated the docs preview:
https://72837--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@tmalove
Copy link
Contributor Author

tmalove commented Mar 8, 2024

/retest

@tmalove tmalove force-pushed the sd-port-security-tlove-main-branch branch from 0bdf6a7 to 4fbd393 Compare March 8, 2024 15:25
@tmalove
Copy link
Contributor Author

tmalove commented Mar 8, 2024

/retest

@tmalove tmalove force-pushed the sd-port-security-tlove-main-branch branch from 4c87810 to 7e9bc79 Compare March 8, 2024 20:22
@tmalove
Copy link
Contributor Author

tmalove commented Mar 11, 2024

/test validate-asciidoc

@tmalove tmalove mentioned this pull request Mar 11, 2024
Closed
1 task
@tmalove tmalove force-pushed the sd-port-security-tlove-main-branch branch from 7e9bc79 to 5032383 Compare March 12, 2024 03:28
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2024
@tmalove tmalove force-pushed the sd-port-security-tlove-main-branch branch 2 times, most recently from a257abb to 5911bd4 Compare March 16, 2024 00:14
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 16, 2024
@tmalove tmalove force-pushed the sd-port-security-tlove-main-branch branch 2 times, most recently from 70b4ecd to 4e050cf Compare March 18, 2024 17:35
@tmalove
Copy link
Contributor Author

tmalove commented Mar 18, 2024

@arendej @rhmdnd @BillDett Will you take a look at the updated preview and let me know if you have any comments or ack. Thanks!

@tmalove tmalove force-pushed the sd-port-security-tlove-main-branch branch from 4e050cf to aba99dc Compare April 5, 2024 14:25
lunarwhite
lunarwhite reviewed Apr 11, 2024
View reviewed changes
Copy link
Member

@lunarwhite lunarwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tmalove, notice that the cert-manager operator sections have been removed in this PR. Is that intended?

@tmalove tmalove force-pushed the sd-port-security-tlove-main-branch branch from 0217ad6 to 0957b52 Compare May 30, 2024 17:50
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed May 30, 2024
View reviewed changes
security/file_integrity_operator/file-integrity-operator-troubleshooting.adoc
Resolution::
To see the `FileIntegrity` object's current status, run:
+
ifndef::openshift-dedicated,openshift-rosa[]
Copy link
Collaborator

@ocpdocs-vale-bot ocpdocs-vale-bot May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDoc.ValidConditions: File contains unbalanced if statements. Review the file to ensure it contains matching opening and closing if statements.

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed May 30, 2024
View reviewed changes
security/file_integrity_operator/file-integrity-operator-troubleshooting.adoc
$ oc get fileintegrities/worker-fileintegrity -o jsonpath="{ .status }"
----
endif[]
ifdef::openshift-dedicated.openshift-rosa[]
Copy link
Collaborator

@ocpdocs-vale-bot ocpdocs-vale-bot May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] AsciiDoc.ValidConditions: File contains unbalanced if statements. Review the file to ensure it contains matching opening and closing if statements.

@tmalove tmalove force-pushed the sd-port-security-tlove-main-branch branch from 0957b52 to 1c91eb6 Compare May 31, 2024 22:45
@openshift-ci
Copy link

openshift-ci bot commented May 31, 2024

@tmalove: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate-portal 096df32 link true /test validate-portal

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

openshift-bot commented Aug 30, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 30, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2024
@openshift-bot
Copy link

openshift-bot commented Sep 29, 2024

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 29, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2024
@openshift-bot
Copy link

openshift-bot commented Oct 30, 2024

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2024
@openshift-merge-robot
Copy link

openshift-merge-robot commented Oct 30, 2024

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot closed this Oct 30, 2024
@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2024

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@lunarwhite lunarwhite lunarwhite left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tmalove @ocpdocs-previewbot @openshift-bot @openshift-merge-robot @lunarwhite @ocpdocs-vale-bot