-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[OSDOCS-9635]: Update roles for the osd-ccs-admin service account #72303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello. I have been asked to have several reviewers for this PR. These individuals include @lento-sun, @ckandag, @renan-campos, @JakobGray, and @NautiluX. FYI: There are two places in the docs that needed to be updated with the list of necessary roles for the osd-ccs-admin SA. I used the official titles (I believe) for each of these roles based on how they are presented in Google docs and the GCP console. Thank you! |
|
🤖 Tue Mar 05 17:19:02 - Prow CI generated the docs preview: |
|
Looks good. Thanks @mletalie |
|
SRE has signed off with LGTM per https://redhat-internal.slack.com/archives/CB53T9ZHQ/p1709194777951929?thread_ts=1709013251.809759&cid=CB53T9ZHQ |
|
/lgtm thx @mletalie |
Thanks! |
|
/label peer-review-needed |
kcarmichael08
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
/label merge-review-needed |
|
/remove-label merge-review-needed |
mletalie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/remove-label merge-review-needed
|
@mletalie: Those labels are not set on the issue: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
FYI based on my conversation with developer on https://issues.redhat.com//browse/OSDOCS-4157, going to not include "IAM" in role names as suggested above. Given that, will need to change in OCP docs in separate ticket. |
|
The updated list (with Role Administrator included per SRE feedback) looks good. |
|
@mletalie: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.15 |
|
/cherrypick enterprise-4.16 |
|
@EricPonvelle: new pull request created: #72642 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@EricPonvelle: new pull request created: #72643 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Version(s):
4.15+
Issue:
https://issues.redhat.com/browse/OSDOCS-9635
Link to docs preview:
https://72303--ocpdocs-pr.netlify.app/openshift-dedicated/latest/osd_install_access_delete_cluster/creating-a-gcp-cluster#osd-create-gcp-cluster-ccs_osd-creating-a-cluster-on-gcp

https://72303--ocpdocs-pr.netlify.app/openshift-dedicated/latest/osd_planning/gcp-ccs#ccs-gcp-customer-procedure_gcp-ccs

QE review:
Additional information:
PM, QE, SRE has signed off. Ready for publication.