Skip to content

Conversation

@mletalie
Copy link
Contributor

@mletalie mletalie commented Feb 28, 2024

@mletalie mletalie changed the title update roles for the osd-ccs-admin service account [OSDOCS-9635]: Update roles for the osd-ccs-admin service account Feb 28, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 28, 2024
@mletalie
Copy link
Contributor Author

mletalie commented Feb 28, 2024

Hello. I have been asked to have several reviewers for this PR. These individuals include @lento-sun, @ckandag, @renan-campos, @JakobGray, and @NautiluX.

FYI: There are two places in the docs that needed to be updated with the list of necessary roles for the osd-ccs-admin SA. I used the official titles (I believe) for each of these roles based on how they are presented in Google docs and the GCP console.
Feedback is appreciated/necessary to get these docs updated. Thanks!

Thank you!

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 28, 2024

🤖 Tue Mar 05 17:19:02 - Prow CI generated the docs preview:
https://72303--ocpdocs-pr.netlify.app

@svmrh
Copy link

svmrh commented Feb 28, 2024

Looks good. Thanks @mletalie

@mletalie
Copy link
Contributor Author

@lentosun
Copy link

lentosun commented Mar 1, 2024

/lgtm thx @mletalie

@mletalie
Copy link
Contributor Author

mletalie commented Mar 1, 2024

/lgtm thx @mletalie

Thanks!

@mletalie
Copy link
Contributor Author

mletalie commented Mar 1, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 1, 2024
@kcarmichael08 kcarmichael08 added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 1, 2024
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kcarmichael08 kcarmichael08 added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.15 branch/enterprise-4.16 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Mar 1, 2024
@kcarmichael08 kcarmichael08 added this to the Continuous Release milestone Mar 1, 2024
@mletalie
Copy link
Contributor Author

mletalie commented Mar 1, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 1, 2024
@mletalie
Copy link
Contributor Author

mletalie commented Mar 1, 2024

/remove-label merge-review-needed

Copy link
Contributor Author

@mletalie mletalie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 1, 2024
@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2024

@mletalie: Those labels are not set on the issue: merge-review-needed

Details

In response to this:

/remove-label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mletalie
Copy link
Contributor Author

mletalie commented Mar 4, 2024

FYI based on my conversation with developer on https://issues.redhat.com//browse/OSDOCS-4157, going to not include "IAM" in role names as suggested above. Given that, will need to change in OCP docs in separate ticket.
https://redhat-internal.slack.com/archives/D06MVE393K6/p1709567541756919

@svmrh
Copy link

svmrh commented Mar 5, 2024

The updated list (with Role Administrator included per SRE feedback) looks good.

@openshift-ci
Copy link

openshift-ci bot commented Mar 5, 2024

@mletalie: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@EricPonvelle EricPonvelle merged commit b77ab73 into openshift:main Mar 5, 2024
@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.15

@EricPonvelle
Copy link
Contributor

/cherrypick enterprise-4.16

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #72642

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@EricPonvelle: new pull request created: #72643

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.15 branch/enterprise-4.16 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants