Skip to content

follow up edits #6610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mburke5678 wants to merge 1 commit into from
Closed

follow up edits #6610

mburke5678 wants to merge 1 commit into from

Conversation

@mburke5678
Copy link
Contributor

@mburke5678 mburke5678 commented Dec 5, 2017

Follow up to #6020

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 5, 2017
@mburke5678 mburke5678 mentioned this pull request Dec 5, 2017
Merged
@mburke5678
Copy link
Contributor Author

mburke5678 commented Dec 5, 2017

@aheslin @adellape Can you take a look at the additions through #6020 ?
I am not sure the link to Dedicated is appropriate in the Adv Install and links to Dedicated and Online in Planning. At this point, the user, I assume, knows what he/she wants to install.
Likewise with the cloud install in Adv. Install. Seems confusing here.
There is a reference, too, to using the OpenStack CLI to install OpenShift on OpenStack. Should that be in the Adv Install? Should that be in Planning?

bogdando
bogdando approved these changes Dec 6, 2017
View reviewed changes
Copy link

@bogdando bogdando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@mburke5678 mburke5678 closed this Dec 6, 2017
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2017
@mburke5678 mburke5678 reopened this Dec 6, 2017
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2017
adellape
adellape reviewed Dec 6, 2017
View reviewed changes
install_config/install/advanced_install.adoc Outdated
Copy link
Contributor

@adellape adellape Dec 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing word here due to the relocated link.

@aheslin
Copy link

aheslin commented Dec 6, 2017

@mburke5678 I agree that the links to Dedicated don't need to be in the Advanced Installer topic. It veers towards marketing content.

@mburke5678 mburke5678 mentioned this pull request Dec 11, 2017
Merged
@mburke5678
Copy link
Contributor Author

mburke5678 commented Dec 20, 2017

Closing. This PR was a follow-up to #6020 which contained suggestions to use Dedicated. The PR was accidentally merged to master (not cherry-picked to any staging branch). This PR was for a proofread pass and edits. The references to Dedicated were rejected by aheslin and backed out via a different PR. I am closing this PR and will make proofread edits to bogdando's remaining text through #6700

@mburke5678 mburke5678 closed this Dec 20, 2017
@mburke5678 mburke5678 deleted the followup-6020 branch August 2, 2018 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@adellape adellape adellape left review comments

@bogdando bogdando bogdando approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mburke5678 @aheslin @bogdando @adellape @openshift-ci-robot