Rename openshift_hosted_router_selector #6609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable openshift_hosted_router_selector is now openshift_router_selector. In this same document openshift_router_selector is already used. Reference: openshift/openshift-ansible@4b0f521
openshift-ci-robot
added
the
size/XS
Contributor
Author
|
bump, @ahardin-rh maybe? |
Contributor
|
@juanluisvaladas Thank you! I see another instance used in https://docs.openshift.com/container-platform/3.7/install_config/router/default_haproxy_router.html, so I will create a companion PR to address that instance. I have this labeled for OCP 3.7 docs and later. Please let me know if this also applies to any earlier versions. |
Contributor
Author
|
Hi, only 3.7 and later is correct |
Contributor
|
No revision history needed. |
ahardin-rh
pushed a commit
to ahardin-rh/openshift-docs
that referenced
this pull request
Jan 2, 2018
The variable openshift_hosted_router_selector is now openshift_router_selector. In this same document openshift_router_selector is already used. Reference: openshift/openshift-ansible@4b0f521 (cherry picked from commit e4cd20c) xref:openshift#6609
ahardin-rh
pushed a commit
to ahardin-rh/openshift-docs
that referenced
this pull request
Jan 2, 2018
The variable openshift_hosted_router_selector is now openshift_router_selector. In this same document openshift_router_selector is already used. Reference: openshift/openshift-ansible@4b0f521 (cherry picked from commit e4cd20c) xref:openshift#6609
This was referenced Jan 2, 2018
This was referenced Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable openshift_hosted_router_selector is now openshift_router_selector. In this same
document openshift_router_selector is already used.
Reference:
openshift/openshift-ansible@4b0f521