OSDOCS-5567: replacing OSUS mirroring admonition #57578
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@skopacz1: This pull request references OSDOCS-5567 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@skopacz1: This pull request references OSDOCS-5567 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/XS
|
🤖 Tue Oct 08 13:41:27 - Prow CI generated the docs preview: |
|
@skopacz1: This pull request references OSDOCS-5567 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
||
| [IMPORTANT] | ||
| ==== | ||
| To avoid excessive memory usage by the OpenShift Update Service application, you must mirror release images to a separate repository as described in the following procedure. |
There was a problem hiding this comment.
We also want to bring back this command (also visible here, since linking to code in a file a pull request deletes seems unreliable) to accomplish that, when re-hydrating oc adm release mirror ... content on the mirrored registry. #33841 has the original implementation of this behavior and a commit message with more context, in case that's helpful.
There was a problem hiding this comment.
Mirroring to a separate repository is mandatory for OSUS only while the section works for both upgrading with OSUS and without OSUS. So I'd suggest we add a step in the end of the section, for example
[IMPORTANT]
====
If you want to update your cluster using the OpenShift Update Service application, you must mirror release images to a separate repository as described in the following procedure. Otherwise, you can skip the step
====
5. Mirror release images to a separate repository
$ oc image mirror -a ${LOCAL_SECRET_JSON} ${LOCAL_REGISTRY}/${LOCAL_REPOSITORY}:${OCP_RELEASE}-${ARCHITECTURE} ${LOCAL_REGISTRY}/${LOCAL_RELEASE_IMAGES_REPOSITORY}:${OCP_RELEASE}-${ARCHITECTURE}
There was a problem hiding this comment.
@wking and @shellyyang1989 how about if I begin both of these added steps with a statement that it's only applicable to OSUS users?
for example: vi. If you are using the OpenShift Update Service, mirror release images to a separate repository
I think this aligns with how we're supposed to write conditional steps per the style guide (that is, forming the instruction like "if you , do this step")
It can also be phrased like "OSUS users only: do this step"
There was a problem hiding this comment.
If you meant adding the statement to below steps, it's fine with me.
.. Export an additional local repository name to contain the release images:
+
[source,terminal]
----
$ LOCAL_RELEASE_IMAGES_REPOSITORY='<local_release_images_repository_name>'
----
+
For `<local_release_images_repository_name>`, specify the name of the repository to
create in your registry, such as `ocp4/openshift4-release-images`.
and
... Mirror the release image to a separate repository:
+
[source,terminal]
----
$ oc image mirror -a ${LOCAL_SECRET_JSON} ${LOCAL_REGISTRY}/${LOCAL_REPOSITORY}:${OCP_RELEASE}-${ARCHITECTURE} ${LOCAL_REGISTRY}/${LOCAL_RELEASE_IMAGES_REPOSITORY}:${OCP_RELEASE}-${ARCHITECTURE}
But we still need to append the step Mirror the release image to a separate repository to the last step If the local container registry and the cluster are connected to the mirror host, directly push the release images to the local registry and apply the config map to the cluster by using following command: because it is mirroring the manifests and release images to the same repository.
There was a problem hiding this comment.
@shellyyang1989 Okay thank you for clarifying, I understand what you mean. Sorry for any confusion!
Could you take a look at the procedure again to see if I made the changes you were imagining for that final step you mentioned?
openshift-ci
bot
added
size/S
|
@shellyyang1989 PTAL, thank you |
openshift-ci
bot
added
size/M
|
/lgtm |
|
@skopacz1: This pull request references OSDOCS-5567 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
|
/remove-label peer-review-needed |
openshift-ci
bot
added
peer-review-in-progress
|
/remove-label peer-review-in-progress |
openshift-ci
bot
added
peer-review-done
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
mburke5678
added
merge-review-in-progress
|
/cherrypick enterprise-4.9 |
|
@mburke5678: new pull request created: #57879 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.10 |
|
/cherrypick enterprise-4.11 |
|
/cherrypick enterprise-4.12 |
|
/cherrypick enterprise-4.13 |
|
@mburke5678: new pull request created: #57880 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #57881 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #57882 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mburke5678: new pull request created: #57883 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8 participants
OSDOCS-5567
Versions: 4.9+
This PR replaces an admonition that was accidentally removed in #55448
QE review:
Preview: https://57578--docspreview.netlify.app/openshift-enterprise/latest/updating/updating-restricted-network-cluster/mirroring-image-repository.html#update-mirror-repository-adm-release-mirror_mirroring-ocp-image-repository