Updating imagecontentsourcepolicy should not trigger a node drain

[mburke5678]

Update the list of MC changes that do not trigger an MCO reboot of the nodes.
https://issues.redhat.com/browse/RFE-2883

Converted the list of conditions that do not trigger a node reboot to a snippet. Updated the list of registries.confchanges based on MCO internal docs.

Previews:
Disabling the Machine Config Operator from automatically rebooting

About the Machine Config Operator

QE review:

• QE has approved this change.

[ocpdocs-previewbot]

🤖 Build preview is available at:
https://57440--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/11541

[sinnykumari]

Thanks Michael for updating this section.
/lgtm

[mburke5678]

@mike-nguyen You reviewed the addition of these conditions. Are you willing and able to take a look at the slight modifications?

[mike-nguyen]

@mburke5678 I haven't worked on the MCO for quite some time. @rioliu-rh can you have the appropriate QE contact review this?

[rioliu-rh]

/cc @xiuwang
can you take a look from image-registry perspective? thanks

[rioliu-rh]

@mburke5678 ImageDigestMirrorSet and ImageTagMirrorSet are new resource to us. we need to verify the behavior mentioned in the doc

[sergiordlr]

I have verified the behavior today:

• ImageDigestMirrorSet applies the mirrors with pull-from-mirror = "digest-only" and the drain operation is skipped.

• ImageTagMirrorSet applies the mirrors with pull-from-mirror = "tag-only" and it performs a drain operation as expected.

[sergiordlr]

It looks good to me.

[snarayan-redhat]

Looks great!

[mburke5678]

/cherrypick enterprise-4.8

[openshift-cherrypick-robot]

@mburke5678: #57440 failed to apply on top of branch "enterprise-4.8":

Applying: Updating imagecontentsourcepolicy should not trigger a node drain
.git/rebase-apply/patch:17: trailing whitespace.
[NOTE] 
.git/rebase-apply/patch:78: new blank line at EOF.
+
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	modules/troubleshooting-disabling-autoreboot-mco.adoc
M	modules/understanding-machine-config-operator.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/understanding-machine-config-operator.adoc
CONFLICT (content): Merge conflict in modules/understanding-machine-config-operator.adoc
Auto-merging modules/troubleshooting-disabling-autoreboot-mco.adoc
CONFLICT (content): Merge conflict in modules/troubleshooting-disabling-autoreboot-mco.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Updating imagecontentsourcepolicy should not trigger a node drain
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mburke5678]

/cherrypick enterprise-4.13

[openshift-cherrypick-robot]

@mburke5678: new pull request created: #57716

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.