-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[OSDOCS-5240] Installer support to automatically create the MachineSets when installing in existing VPC on AWS w/Local Zones #57427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
maxwelldb
merged 42 commits into
openshift:main
from
maxwelldb:aws-local-zones-existing-vpc-osdocs5240
May 11, 2023
Merged
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
98197c7
Dump converted content
maxwelldb 15d17f3
Beginning re-org of existing content
maxwelldb bb83782
Update CloudFormation VPC template
maxwelldb 1237a0e
Update subnet template
maxwelldb b9936ac
Add IAM policy to assembly prereqs
maxwelldb eaaeb78
Add sample deployment ref
maxwelldb 496adc0
rm working assembly -- no longer needed
maxwelldb 7da2960
Add Local Zone note to install-config params mod
maxwelldb 9fc030d
Level fixes
maxwelldb a89d6d5
Tweak user-infra-generate module language
maxwelldb 84d5a91
Add 'create install-config' module
maxwelldb 8a11a48
Label update
maxwelldb aea6887
Subnets list update
maxwelldb 2c35d88
Adding module
maxwelldb f2fe73b
Apply first batch of suggestions from dev review
maxwelldb 3ae9694
Apply some suggestions from dev review
maxwelldb 50910f5
Update edge pools concept mod
maxwelldb 5bb7a83
Remove ClusterName from param file
maxwelldb 04512b4
Update local zone list command
maxwelldb a367a1c
Attempt to address zone_identifier feedback
maxwelldb 7669c7a
zone group name syntax change
maxwelldb a15f2b9
Remove unused modules
maxwelldb 7ac794c
Revert "Remove unused modules"
maxwelldb 0a14b57
Redo on the rms
maxwelldb 90bb2fe
Apply suggestions from review
maxwelldb cbf361e
Remove installation-aws-local-zones-ref-deployment
maxwelldb e360778
Update subnets in example
maxwelldb 5cdde5c
Repurpose 'add subnets to config' mod
maxwelldb 73920b0
fixup! Repurpose 'add subnets to config' mod
maxwelldb 73048b4
Change level for Edge compute pools mod
maxwelldb 1a6e9c3
Correct subnets list callout
maxwelldb c3c3636
simplifying the Zone group explanation for Local Zones OSDOCS-5240 (#3)
mtulio da5f295
Subnets module attempt 1
maxwelldb f2db161
OSDOCS-5240 #57427: review rendered page with important fixes on the …
mtulio 562bc09
Remove errant markup from GH suggestion
maxwelldb e75e04f
Nits
maxwelldb 5171315
Apply suggestions from code review
maxwelldb 9c0b11b
Apply some suggestions from code review
maxwelldb a90cea2
Gerund form for procedure
maxwelldb ecfe528
Update param key and val block
maxwelldb 184bb7e
Add module use comment
maxwelldb c83a45c
Apply suggestions from peer review
maxwelldb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // Module included in the following assemblies: | ||
| // * installing/installing_aws/installing-aws-localzone.adoc | ||
|
|
||
| :_content-type: CONCEPT | ||
maxwelldb marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| [id="edge-machine-pools-aws-local-zones_{context}"] | ||
| = Edge compute pools and AWS Local Zones | ||
|
|
||
| Edge worker nodes are tainted worker nodes that run in AWS Local Zones locations. | ||
|
|
||
| When deploying a cluster that uses Local Zones: | ||
|
|
||
| * Amazon EC2 instances in the Local Zones are more expensive than Amazon EC2 instances in the Availability Zones. | ||
| * Latency between applications and end users is lower in Local Zones, and it may vary by location. There is a latency impact for some workloads if, for example, routers are mixed between Local Zones and Availability Zones. | ||
| * The cluster-network Maximum Transmission Unit (MTU) is adjusted automatically to the lower restricted by AWS when Local Zone subnets are detected on the `install-config.yaml`, according to the network plugin. For example, the adjusted values are 1200 for OVN-Kubernetes and 1250 for OpenShift SDN. If additional features are enabled, manual MTU adjustment can be necessary. | ||
|
|
||
| [IMPORTANT] | ||
| ==== | ||
| Generally, the Maximum Transmission Unit (MTU) between an Amazon EC2 instance in a Local Zone and an Amazon EC2 instance in the Region is 1300. For more information, see link:https://docs.aws.amazon.com/local-zones/latest/ug/how-local-zones-work.html[How Local Zones work] in the AWS documentation. | ||
| The cluster network MTU must be always less than the EC2 MTU to account for the overhead. The specific overhead is determined by the network plugin, for example: | ||
|
|
||
| - OVN-Kubernetes: `100 bytes` | ||
| - OpenShift SDN: `50 bytes` | ||
|
|
||
| The network plugin can provide additional features, like IPsec, that also must be decreased the MTU. For additional information, see the documentation. | ||
| ==== | ||
35 changes: 35 additions & 0 deletions
35
modules/install-creating-install-config-aws-local-zones.adoc
maxwelldb marked this conversation as resolved.
Show resolved
Hide resolved
maxwelldb marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| // Module included in the following assemblies: | ||
| // * installing/installing_aws/installing-aws-localzone.adoc | ||
|
|
||
| :_content-type: PROCEDURE | ||
maxwelldb marked this conversation as resolved.
Show resolved
Hide resolved
maxwelldb marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| [id="install-creating-install-config-aws-local-zones_{context}"] | ||
| = Modifying an installation configuration file to use AWS Local Zones subnets | ||
|
|
||
| Modify an `install-config.yaml` file to include AWS Local Zones subnets. | ||
|
|
||
| .Prerequisites | ||
|
|
||
| * You created subnets by using the procedure "Creating a subnet in AWS Local Zones". | ||
| * You created an `install-config.yaml` file by using the procedure "Creating the installation configuration file". | ||
|
|
||
| .Procedure | ||
|
|
||
| * Add the VPC and Local Zone subnets as the values of the `platform.aws.subnets` property. As an example: | ||
| + | ||
| [source,yaml] | ||
| ---- | ||
| ... | ||
| platform: | ||
| aws: | ||
| region: us-west-2 | ||
| subnets: <1> | ||
| - publicSubnetId-1 | ||
| - publicSubnetId-2 | ||
| - publicSubnetId-3 | ||
| - privateSubnetId-1 | ||
| - privateSubnetId-2 | ||
| - privateSubnetId-3 | ||
| - publicSubnetId-LocalZone-1 | ||
| ... | ||
| ---- | ||
| <1> List of subnets created in the Availability and Local Zones. | ||
maxwelldb marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.