Skip to content

Conversation

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 6, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2023

@skopacz1: This pull request references OSDOCS-4744 which is a valid jira issue.

Details

In response to this:

OSDOCS-4744

This is the 4.8 PR of #55448

Preview: http://file.bos.redhat.com/skopacz/4744_4.8/updating/updating-restricted-network-cluster/mirroring_image_repository.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 6, 2023

@skopacz1 skopacz1 force-pushed the 4744_4.8 branch 2 times, most recently from d9f640c to 3f9bf50 Compare February 9, 2023 20:41
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2023

@skopacz1
Copy link
Contributor Author

@shellyyang1989 PTAL

@shellyyang1989
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
@openshift-ci
Copy link

openshift-ci bot commented Feb 23, 2023

New changes are detected. LGTM label has been removed.

@skopacz1
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 27, 2023
@mburke5678
Copy link
Contributor

@skopacz1 LGTM. Are we still merging to 4.8? We aren't publishing that branch on a daily basis.

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.10 and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 27, 2023
@mburke5678 mburke5678 added this to the Continuous Release milestone Feb 27, 2023
@mburke5678 mburke5678 removed this from the Continuous Release milestone Feb 27, 2023
@skopacz1
Copy link
Contributor Author

@mburke5678 I got the go ahead from Kathryn to merge this one PR, which was in progress by the time 4.8 support was cut off. I just have to let them know when this is merged so the new changes can be published manually.

@mburke5678 mburke5678 merged commit 3d90dc1 into openshift:enterprise-4.8 Feb 27, 2023
@mburke5678 mburke5678 added this to the Continuous Release milestone Feb 27, 2023
@skopacz1 skopacz1 deleted the 4744_4.8 branch October 31, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.8 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants